Comments (20)
I have finally fixed the issue causing this to not be released. It should be out soon.
from fluffyspoon.aspnet.encryptwemust.
@ffMathy please let us know if this will be fixed anytime soon. My production env is down at the moment. We have to find some other solution if this is not going to be fixed. Thanks.
from fluffyspoon.aspnet.encryptwemust.
Hi! A PR is welcome where the NuGet package is updated.
from fluffyspoon.aspnet.encryptwemust.
I tried, but with and without Nuget update in both cases, this test case is failing.
from fluffyspoon.aspnet.encryptwemust.
I'm sorry, I just don't have much time at the moment. Is it possible for you to switch to LettuceEncrypt?
If your servers are down, can you trigger the renewal process manually?
from fluffyspoon.aspnet.encryptwemust.
I have updated the code here and fixed the unit tests. Not sure if I fixed the issue or did something sub optimal.
I don't have access to this repo, so changes are there in my repo
https://github.com/patolax/EncryptWeMust
only a few changes, 2 project files, and minor changes to
FluffySpoon.AspNet.EncryptWeMust-master\FluffySpoon.AspNet.EncryptWeMust\src\FluffySpoon.AspNet.EncryptWeMust\Certes\LetsEncryptClient.cs
from fluffyspoon.aspnet.encryptwemust.
@ffMathy I can confirm that after my updates certificate renewal is now working. I had to compile my version of the lib and refer to that to test in the production environment.
It would be great if you could release a new version after these two line changes or allow me to create a PR. Thank you!
from fluffyspoon.aspnet.encryptwemust.
Make a PR, then I will get it merged immediately 😄
Everybody can create PRs for any repo on GitHub. Just go to your own fork, and click "create pull request".
from fluffyspoon.aspnet.encryptwemust.
Oh, you recloned the repo and republished it. Please use the official GitHub forking feature. Then a PR can be created more easily.
from fluffyspoon.aspnet.encryptwemust.
Thanks. Here it is.
BTW, there is another thing related to staging I think.
But I don't know where I can find Issuers. This is what I was able to find in LettuceEncrypt.
var pfxBuilder = _pfxBuilderFactory.FromChain(certificateChain, certKey);
_logger.LogDebug(
"Adding {IssuerCount} additional issuers to certes before building pfx certificate file",
_options.Value.AdditionalIssuers.Length + _certificateAuthority.IssuerCertificates.Length);
foreach (var issuer in _options.Value.AdditionalIssuers.Concat(_certificateAuthority.IssuerCertificates))
{
pfxBuilder.AddIssuer(Encoding.UTF8.GetBytes(issuer));
}
from fluffyspoon.aspnet.encryptwemust.
I merged it, but then I spotted that you are now omitting a PreferredChain
option, so I reverted it again. Can you elaborate on this?
from fluffyspoon.aspnet.encryptwemust.
test cases failed if you don't remove it
Code from LettuceEncrypt
return await order.Generate(csrInfo, privateKey);
change from my PR
await order.Generate(_options.CertificateSigningRequest, keyPair);
from fluffyspoon.aspnet.encryptwemust.
What happens if you instead set PreferredChain
to "ISRG Root X2" instead of the default "ISRG Root X1"?
I don't think we should remove the PreferredChain call. Or at least we should remove the property from the LetsEncryptOptions object too.
from fluffyspoon.aspnet.encryptwemust.
Sorry I am not an expert, I only tried to fix the tests. But here are some related links
from fluffyspoon.aspnet.encryptwemust.
@ffMathy the following change still fails tests. It only passes if I remove the parameter as I have done in my PR.
public string PreferredChain { get; set; } = "ISRG Root X2";
from fluffyspoon.aspnet.encryptwemust.
Alright. If you remove the property from the setting object too, then I'll merge it. Thanks.
from fluffyspoon.aspnet.encryptwemust.
Done
from fluffyspoon.aspnet.encryptwemust.
from fluffyspoon.aspnet.encryptwemust.
@ffMathy has the new package been released? I could not find it from Nuget.
from fluffyspoon.aspnet.encryptwemust.
@ffMathy do not see the new package now. My production server is still using the 1.171.0 and failing. The certificate is about to expire in a week. Is it possible to release this anytime soon? thanks a lot.
from fluffyspoon.aspnet.encryptwemust.
Related Issues (20)
- Target latest lts .net core HOT 2
- Fail to load resource from 'https://acme-v02.api.letsencrypt.org/acme/new-order': urn:ietf:params:acme:error:badNonce HOT 12
- Challenge fails with Connection refused (challenge type http-01) HOT 4
- adding domain names fails HOT 3
- Would a PR to increase/improve logging be accepted? HOT 2
- Azure will not let certificates be updated if they're in use HOT 2
- Azure deployment slot support HOT 2
- Azure support without needing to load X509 certs HOT 1
- Main package missing after rename HOT 6
- Sample looking for `localhost` developer cert upon start HOT 2
- Now that "LetsEncryptRenewalService.Certificate" is internal, how do you get the cert for ServerCertificateSelector? HOT 4
- Samples for adding new domains during runtime
- One or more errors occurred. | unauthorized: Invalid response | 404 Not Found
- Kestrel could not be started. HOT 6
- Please make certificate password changable, this is a sequrity threat. HOT 5
- Failure to order certificate for multiple domains HOT 2
- Error with .NET 6 HOT 3
- When having IIS in front ... HOT 1
- Do we need to open port 80 or can some other port be assigned HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluffyspoon.aspnet.encryptwemust.