GithubHelp home page GithubHelp logo

Doesn't support IE 9-11 about formous HOT 8 CLOSED

ffxsam avatar ffxsam commented on July 26, 2024
Doesn't support IE 9-11

from formous.

Comments (8)

ffxsam avatar ffxsam commented on July 26, 2024

Fixed in the latest release

from formous.

kaatt avatar kaatt commented on July 26, 2024

Thanks. I'm using webpack and uglify. Shouldn't that code be automatically removed because it's related to the tests (I checked the latest commit diff) or am I misunderstanding something?

from formous.

ffxsam avatar ffxsam commented on July 26, 2024

Not those kinds of tests. The code in dx.js is "developer experience" related, which just provides a bunch of checks to make sure that a developer is using Formous properly. And it's checking to make sure the Formous tests are listed in the correct order (non-critical always after critical tests).

from formous.

kaatt avatar kaatt commented on July 26, 2024

Should use NODE_ENV !== production for that probably?

I just checked, the latest update increased my webpack bundle size (after uglify) about ~80 KB. I'm guessing the complete lodash is getting included. (#18 is a fix)

from formous.

ffxsam avatar ffxsam commented on July 26, 2024

Should use NODE_ENV !== production for that probably?

Ah, yes! Very good point. I'll add it when I get time, or you're welcome to do a PR.

I just checked, the latest update increased my webpack bundle size (after uglify) about ~80 KB. I'm guessing the complete lodash is getting included.

Another good point. I see you just did a PR for this, I'll check it out.

from formous.

kaatt avatar kaatt commented on July 26, 2024

I'll check what they do in other libraries and try to make a PR.

Do you dogfood this library?

from formous.

ffxsam avatar ffxsam commented on July 26, 2024

Yep, all my repos are dogfooded. :) I usually build them out of a need I have, and then release it publicly.

BTW, I would try to limit the amount of PRs for now. I have a big code health update planned when I have time, which will probably change 20-25% of the codebase. At some point I'll also add support for dropdowns and radio buttons as well.

from formous.

kaatt avatar kaatt commented on July 26, 2024

Great, hope to see something for #14 soon

from formous.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.