Comments (1)
Mint Thompson (They/Them/Theirs):theythem-teal: 9 hours ago
this is baffling. i'll take a look at it
Mark Kramer 9 hours ago
Thank you!
Nick Freiter (He/Him/His) 9 hours ago
But then if you run SUSHI on the version with SNOMED_CT, it runs without error right? I think it is using the SNOMED_CT CodeSystem, which is defined as part of the FHIR spec: https://www.hl7.org/fhir/codesystem-snomedct.json.html
Nick Freiter (He/Him/His) 9 hours ago
Notice the name, SNOMED_CT
Nick Freiter (He/Him/His) 9 hours ago
So itโs just preferring to use the name of a known resource over an alias
Mint Thompson (They/Them/Theirs):theythem-teal: 9 hours ago
oh, huh, you're right. the rule has SNOMED_CT, and it converts it to JSON in fsh online without an error
Nick Freiter (He/Him/His) 9 hours ago
Yeah if you check the url on the SNOMED_CT resource, it is http://snomed.info/sct. So it makes sense we would resolve that url to the existing resource. Itโs a weird special case that that resource is defined in FHIR, but I think GoFSH is behaving correctly here
Mark Kramer 9 hours ago
That is weird. I never would have guessed. Do you want me to close the bug report?
Nick Freiter (He/Him/His) 8 hours ago
Yeah unless we want to do something special for snomed, we can close it as not a bug
Mark Kramer 8 hours ago
I seem to be reporting many not-a-bugs. ๐ฅธ
from gofsh.
Related Issues (20)
- How to specify base profiles? HOT 1
- GoFSH should support creating inline instances that have ids that are numbers
- ValueSet expansion.contains rules should not be optimized into a single assignment
- Indenting not working correctly
- GoFSH does not translate extensions on ElementDefinition.type.targetProfile
- FHIR-invalid examples don't give any errors HOT 3
- GoFSH should not combine rules on compose.include.concept on Instances of ValueSets HOT 1
- Cannot roundtrip R5 workflow reason extension HOT 1
- GoFSH should not warn on fixed values in LMs
- Support FSH 3.0 Context keyword
- Support FSH 3.0 Invariant Rules
- Support FSH 3.0 Concept Rules for Value Sets
- Support FSH 3.0 CodeableReference keyword
- Support FSH 3.0 Characteristics keyword
- Improve support for using slices in instances
- French ICD-10 CodeSystem not usable with Sushi after goFSH HOT 1
- GoFSH handles inline CodeSystems poorly
- GoFSH incorrectly converts decimal types to strings HOT 1
- Update Dependencies and Add DEPENDENCY-NOTES.md
- Resolve URL for ValueSets and CodeSystems that must be represented as Instances
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gofsh.