Moving to 2.0.0 about moment.php

[fightbulc]

Hey @ConnerAiken,

I would make a hard cut all versions before php 8. I would keep it around as a fixable version but I would put a hold on further development. Hence, lets branch away from master to create a php-8 branch and lets see what needs to be done to make it pass.

How much time do you have to work on this project?

Greetings
Tino

[ConnerAiken]

@fightbulc As i've been documenting changes for our company's PHP7 -> PHP8 upgrade - it appears to me that we are fully compatible for PHP 7.4 and above. However, PHP 6 and below is not looking too great.

#209 introduces two major changes:

• The use of #[\ReturnTypeWillChange] attribute
  • For PHP versions 8 and below, this get's parsed as a code comment and does not cause any syntax errors.
• The use of return types (albeit with minimal accuracy)
  • Return type declarations appear to have been introduced in 7.1.0 (https://www.php.net/manual/en/language.types.declarations.php)

I have not tested it yet, but I would think it would cause a syntax error for PHP 6 and below.

[ConnerAiken]

One issue i've uncovered with PHP 8 compatibility, we may want to extend the valid checks (isValidDate()) of input to the package or default null parameters to 'now'.

DateTime: :__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in moment/src/Moment.php on line 196

<?php
var_dump(new DateTime(null));
?>

[ConnerAiken]

Hey @ConnerAiken,

I would make a hard cut all versions before php 8. I would keep it around as a fixable version but I would put a hold on further development. Hence, lets branch away from master to create a php-8 branch and lets see what needs to be done to make it pass.

How much time do you have to work on this project?

Greetings

Tino

I have a few hours a week. Ok, all the changes should be php 7.4+ compatible but we could do that. If I understand right - master is "fixable"?