GithubHelp home page GithubHelp logo

Comments (6)

lap00zza avatar lap00zza commented on June 28, 2024 1

Hi, I am getting 3 scrollbars.

  • Browser: Chrome 59.0.3071.115 (Official Build) (64-bit)
  • OS: Windows 8.1

Edit: This middle scrollbar goes away if #_bftn_wrapper is set to overflow-y: auto instead of overflow-y: scroll

from battleforthenet-widget.

mikemorris avatar mikemorris commented on June 28, 2024

I've seen this on IE11 in a VM too, I'm sure there's a fix that involves overflow, but not sure exactly what it is, and we've had issues with iframe scrolling being finnicky on iOS.

from battleforthenet-widget.

as-com avatar as-com commented on June 28, 2024

I think the quickest solution would be to disable scrolling of the body when the modal is open, while still allowing scrolling within the modal wrapper thingy.

from battleforthenet-widget.

mikemorris avatar mikemorris commented on June 28, 2024

I'd be hesitant to push something like that with the widget getting traffic now, don't want to accidentally break everyone's site!

from battleforthenet-widget.

mikemorris avatar mikemorris commented on June 28, 2024

One possible solution to avoid the double scrollbars (and scroll overlap on iOS) could be using the Shadow DOM as browser support allows in createIframe, although I think this may require reworking some structure to @import CSS inline and load remote HTML (probably with fetch if we'd already be restricting this to Shadow DOM support), and possibly other changes?

I'd accept a pull request for either the Shadow DOM approach or simply disabling scrolling while the modal is open and enabling it when the modal is removed.

from battleforthenet-widget.

realsrikar avatar realsrikar commented on June 28, 2024

You don’t need overflow hiddden. You can style the scrollbar using ::-webkit-scrollbar (Needs prefix)

 ::-webkit-scrollbar {
  display: none;
}

Be careful in using this because people who primarily use scrollbar to scroll will not be able to scroll.

from battleforthenet-widget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.