GithubHelp home page GithubHelp logo

Comments (9)

Zenexer avatar Zenexer commented on June 28, 2024 1

Found the bug. It's not setting path=/ for the cookie.

from battleforthenet-widget.

mikemorris avatar mikemorris commented on June 28, 2024

Did you have always_show_widget: true in the config options? If so you can just remove that line to have the expected behavior (we're intentionally using that always-on behavior on /july12 and the widget demo page). Preventing future popups of the widget also does require cookies.

from battleforthenet-widget.

Zenexer avatar Zenexer commented on June 28, 2024

This is happening with the Cloudflare app, too, and there's no option to disable it. Our non-American users in particular are complaining quite a bit, since they can't actually fill out the form. The README made it sound as though it was only going to show once by default. The Cloudflare app also started showing for everyone on July 11 instead of July 12; I reset the app and it seemed to fix the issue.

Here's everyone complaining: https://www.namepros.com/threads/cloudflare-pop-up.1029497/

from battleforthenet-widget.

aikar avatar aikar commented on June 28, 2024

I did not set any configs. just the script tag...

from battleforthenet-widget.

Zenexer avatar Zenexer commented on June 28, 2024

Here's one complaint saying that it keeps popping up even after we switched away from the Cloudflare app: https://www.namepros.com/posts/6253707/ I wasn't able to reproduce the issue, but it sounds like it's on iOS.

from battleforthenet-widget.

Zenexer avatar Zenexer commented on June 28, 2024

@aikar I explicitly set the value to false and that seems to have worked.

More updates on the complaint: https://www.namepros.com/posts/6253756/ (also see response in following post)

Update:

So here is one for you.... on my older iPad (the New Ipad.... er Ipad 3) no issues. Pops up once and thats it.
on my Ipad Air, using Safari browser.... issues.

Doing more testing and will try to get a video.

Video of the issue: https://youtu.be/fd6oKRa7pbs

Code on the website:

<script>window._bftn_options={always_show_widget:false}</script>
<script src="https://widget.battleforthenet.com/widget.js" async></script>

from battleforthenet-widget.

aikar avatar aikar commented on June 28, 2024

@Zenexer I noticed that too

from battleforthenet-widget.

tibetsprague avatar tibetsprague commented on June 28, 2024

good catch!

from battleforthenet-widget.

mikemorris avatar mikemorris commented on June 28, 2024

That would do it - thanks for catching this @Zenexer!

from battleforthenet-widget.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.