GithubHelp home page GithubHelp logo

Comments (9)

ConnorHowell avatar ConnorHowell commented on June 26, 2024

Not really sure this is a bug, it's returning an internal server error because it's reaching the configured PHP max execution time of 30 seconds.

If you're expecting people to be searching such long strings then you should just increase this on your own server.

from filament.

danharrin avatar danharrin commented on June 26, 2024

We could add a max length potentially with validation

from filament.

dreftas avatar dreftas commented on June 26, 2024

@danharrin is it possible to validate search terms now ? I can't find anything related in documentation

from filament.

danharrin avatar danharrin commented on June 26, 2024

Not at the moment, would you submit a PR to add a default max length of 1000 characters?

from filament.

dreftas avatar dreftas commented on June 26, 2024

I'll try and let you know.

from filament.

dreftas avatar dreftas commented on June 26, 2024

I had no luck trying to do that validation for max length, so unfortunately sorry, but I can't make this PR

from filament.

zepfietje avatar zepfietje commented on June 26, 2024

@danharrin, what about we make the search field configurable as a TextInput component?
That would allow for the max length value to be changed (in addition to changing or removing the prefix icon and placeholder).

from filament.

danharrin avatar danharrin commented on June 26, 2024

That would require it to be converted into a form similar to the filters which might be overkill

from filament.

zepfietje avatar zepfietje commented on June 26, 2024

Agree that might be overkill for just this case, but might want to consider it if more requirements come up later (like the stuff I said above).

from filament.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.