GithubHelp home page GithubHelp logo

Comments (4)

nicola avatar nicola commented on August 25, 2024 2

After careful analysis, we reviewed more the security considerations written in the here and we believe that we could temporarily pause this FIP and try to mitigate the issue presented.

Problem: When a miner in-debt recovers sectors via FIP0006, these will count towards the total network QA power - however the miner won't be able to mine since they are still in debt.

Temporary patch: When a miner recovers a sector, this does not count towards total network QA power (e.g. is added to a special list called "recovered sectors") and it will start counting after the miner is out of debt

Final fix: However, this is just patch to the total network QA power inflation and the actual fix that should happen is (1) to refactor eligibility checks to remove power from the power table, rather than checking it at block verification time, (2) apply the above patch. This fix should help the problem above and solve other relevant problems that the temporary patch won't fix.

Ways forward:

  • Ship FIP0006 as it is but with a commitment to the patch or the fix soon (not ideal)
    • Pros: To avoid miners running into more debt
    • Cons: See proposal security considerations
  • Don't ship FIP0006 until temporary patch is shipped and later ship the final fix
    • Pros: Mitigate proposal consideration
    • Cons: Will require a new update eventually with the final fix and it may be a lot of code rewriting
  • Don't ship FIP0006 until the final fix is shipped
    • Pros: GOOD
    • Cons: Might take too long

@nicola @irenegia @zixuanzh, @davidad

from fips.

spacetimedevx avatar spacetimedevx commented on August 25, 2024 1

Thank you very much for the official understanding. In many cases, it is not that miner do not want to restore the power, but it may be impossible to restore it due to various problems in the program and hardware etc.
And the next time recovery needs to pay penalty, but in the case of no definite problem and relatively small power, we will prefer the latter in the choice of whether to continue to pay the penalty or to build a new miner. As a result, the restoration of storage is not active. This feels that it violates the original intention of Filecoin. We should do our best to repair the storage and ensure the integrity of the storage.
I support this proposal very much, and it can help us to make our best efforts to solve the problem and restore storage.

from fips.

tomasd2020 avatar tomasd2020 commented on August 25, 2024

LGTM.

from fips.

jennijuju avatar jennijuju commented on August 25, 2024

This FIP was deferred.

from fips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.