Comments (2)
Are you envisioning this as something that is adjustable from the settings page/tab or within the stepper?
from fillmaster.
Are you envisioning this as something that is adjustable from the settings page/tab or within the stepper?
I think setting it from the settings for now would be best. I want to avoid adding stuff to the stepper if possible unless I've got good reason to. I'd like to keep it as 5 steps. I'll try and do some wireframes at some point for future features.
For now here's a rough sketch of what I was thinking:
I realise this is a little more than described in the issue, but the full feature would probably look something like this. Potentially with the option to change between 4 and 8 bars (which would apply to both fill type and fill start options).
Something like this but open to suggestions.
You could simplify it a bit so there are only two options, static or 'cycle fill type every 4 bars' or just remove the 'alternate' feature which would be a bit more advanced. That would be enough for now, but I thought I'd let you know the full thinking.
When the fill type or fill start reset, it's probably best to re-run the randomiser animation so that the user has feedback that they are changing. They'd have to run a bar early or so, so that the result is ready for the correct bar and the user has plenty of time to read and think about the result, but I haven't thought this through completely how it will look. Something visual on the screen to say 'hey, time to change your fill style'. Perhaps a countdown...
from fillmaster.
Related Issues (20)
- Add local storage for lower and upper tempo limits. HOT 4
- Block landscape orientation on phones HOT 1
- Bug: Sound disappears when navigating away from the app and back (at least on iphone). HOT 2
- Restart CountIn on stop HOT 2
- Make sure fillStarts cannot be greater than beatsPerBar but go up to as high as beatsPerBar (e.g. fill on beat 5 in 5/4 but no fill on beat 4 in 3/4) HOT 2
- Change all arrow functions used for rendering (where possible) to normal functions. HOT 1
- Add option to turn off metronome 'ping' sound for bar start. HOT 1
- Add 'first note only option'. HOT 1
- Epic: Exact tempo & Tap Tempo HOT 2
- Add local storage for time signature and reset option HOT 4
- tests.. more tests - EASY
- Remove the two 'any's from Metronome.tsx HOT 1
- Add some documentation for doing PRs and contributing. HOT 1
- Add ability to use offline (potentially through local storage) HOT 1
- Add ability to change sounds. HOT 1
- Extend patternMaker class HOT 4
- UI bug: Bar disappears from screen on desktop HOT 1
- Display visual metronome hints in lead up to fill sound.
- Add basic Github actions to run tests before PR can be merged HOT 1
- Make tempoPreview class HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fillmaster.