GithubHelp home page GithubHelp logo

Comments (6)

erikras avatar erikras commented on June 25, 2024

The idea, and I think this is mostly the whole point of symbols, is to avoid namespace collision. They could be a string, but that would make a field name invalid.

Are polyfills not sufficient to alleviate your suffering?

from final-form.

Andarist avatar Andarist commented on June 25, 2024

The idea, and I think this is mostly the whole point of symbols, is to avoid namespace collision. They could be a string, but that would make a field name invalid.

Many libraries use some distinct strings for it - in fact context names in legacy context API even couldnt be symbols so strings were enforce. I understand it's not ideal, because name clash is possible, but I think smth like @@final-form/ARRAY_ERROR would be "good enough" and universal.

My use case is pretty niche, but we distribute an installable widget and parts of its code is executed on our customers' website where I cannot just install global polyfill because it might cause numerous unexpected results for them so we avoid it at all costs.

Also this polyfill costs 3kb~ (from what i remember, ive checked it yesterday) which could be avoided.

I understand though that u might not want to migrate off this, as community we probably should start to support more and more es6+ by default, unfortunately on a global market we cannot ship it by default, because our customers expect it to work in IE11, some sandboxed windows "smart clients" (which use IE11 engine under the hood) etc - so overally im torn between wanting to support them and also wanting to finally use newer stuff.

Also I've finally debugged my issue to the core and at least I know what happened - after I have polyfilled Symbols (because final-form required this) I've ended up with other issue in redux because of that. If you are interested (quick read) you might see my redux PR (with explanation what happened) here.

from final-form.

erikras avatar erikras commented on June 25, 2024

Okay. You've convinced me. 👍

from final-form.

Andarist avatar Andarist commented on June 25, 2024

Thanks! 😍

from final-form.

erikras avatar erikras commented on June 25, 2024

Published fix in v4.5.1.

from final-form.

lock avatar lock commented on June 25, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from final-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.