Comments (3)
Thanks for your response!
To be honest, this issue was a bit… misguided. We've actually implemented submitError
handling into our form library now instead of just theorycrafting.
We realised that it's correct (in our case) to always show the field validation error
when present (because we default to disabling the submit button if there are any errors), and only show the submitError
if the field validation passes.
I no longer believe it possible to "solve" this "problem" (if there even is one anymore) in a way that works for (or even helps) everyone in this library, so I'll just close it.
from final-form.
This doesn't seem like a concern this library should dictate. Your concern is that you find yourself doing a lot of this? (react jsx syntax)
<div>
{(error || submitError) && <Error>{error || submitError}</Error>}
</div>
and you'd rather just do
<div>
{mergedError && <Error>{mergedError}</Error>}
</div>
?
from final-form.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from final-form.
Related Issues (20)
- initialValue overrides state on update HOT 1
- How to unregisterField, or at least update the registration? HOT 2
- [Feature Request] Get last dirty state of unregistered field (when `destroyOnUnregister` is false) HOT 2
- Migrate to TypeScript
- keepDirtyOnReinitialize can't handle undefined value HOT 2
- Confusing documentation/messaging
- final-form ^4.20.3 introduced a breaking change for array field names (e.g. choices[]), which worked in v4.20.2 HOT 1
- Field subscription `modifiedSinceLastSubmit`, is defined as `false`, rather than `boolean`. HOT 2
- Issue on TypeScript FieldSubscription
- form state becomes dirty when initial value is empty, and user interacting without actually changing the value HOT 1
- Reacting to onSubmit Promise rejection HOT 1
- focus/change/blur is not a function HOT 5
- Feature: Reuse field states from already created instance HOT 5
- FormSpy components are rendering sooner than previously expected
- FieldArray record level async validation not working HOT 1
- Error with validation when registering array field and array item fields together HOT 1
- Usage of keyof in TypeScript types does not align with field names
- [RFC] TypeScript rewrite of a few Final Form packages HOT 1
- Form not dirty after removing items from FieldArray using final-form-arrays
- Can't register field named 'constructor' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from final-form.