GithubHelp home page GithubHelp logo

Comments (3)

theneva avatar theneva commented on June 25, 2024 1

Thanks for your response!

To be honest, this issue was a bit… misguided. We've actually implemented submitError handling into our form library now instead of just theorycrafting.

We realised that it's correct (in our case) to always show the field validation error when present (because we default to disabling the submit button if there are any errors), and only show the submitError if the field validation passes.

I no longer believe it possible to "solve" this "problem" (if there even is one anymore) in a way that works for (or even helps) everyone in this library, so I'll just close it.

from final-form.

erikras avatar erikras commented on June 25, 2024

This doesn't seem like a concern this library should dictate. Your concern is that you find yourself doing a lot of this? (react jsx syntax)

<div>
  {(error || submitError) && <Error>{error || submitError}</Error>}
</div>

and you'd rather just do

<div>
  {mergedError && <Error>{mergedError}</Error>}
</div>

?

from final-form.

lock avatar lock commented on June 25, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from final-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.