Comments (10)
@aaroncox would this type of fix be beneficial to BPs despite the response data being in the FIO format?
from fio.
I believe so. At that point it might require some validation logic to be changed (if it exists), but will at least allow results to be returned to the client.
from fio.
The following API endpoints could be modified to support this:
- get_fio_balance
- get_pending_fio_requests
- get_sent_fio_requests
- get_obt_data
However, the signing and the responses will still be in the FIO
format.
from fio.
PR Submitted
from fio.
Resolved by #64
from fio.
You can't just replace FIO prefix with PUB_K1 because they are encoding the public key differently, You can see the difference here:
https://github.com/EOSIO/eosjs/blob/master/src/eosjs-numeric.ts#L272
from fio.
here's a better example in c++ https://github.com/EOSIO/abieos/blob/master/src/crypto.cpp#L134
from fio.
Someone floated the idea of just adding a prefix since we still have to use this as a human-readable address people can send to. Is that doable? Something like FIO_PUB_K1_6smr7ThQMWYBHzEvkzTZdxNNmUwxqh2VXdXZdDdzYHgak1U8Di?
from fio.
It should be. Another option would be to use FIO_K1_6smr7ThQMWYBHzEvkzTZdxNNmUwxqh2VXdXZdDdzYHgak1U8Di
(without the PUB
portion)... though you could realistically do either way. The various SDKs would just need updated to support it.
The code @cc32d9 mentioned would need updated, eosjs/fiojs would need updated in the same way, and eosio-core would all have to be updated. It's not a comprehensive list, but those are a few areas I immediately recognize that would need updates.
from fio.
Yeah, I like FIO_KY vs. FIO_PUB_K1. I could think of it this way: "PUB_..." is a generic public key. "FIO_..." is a specific public key.
from fio.
Related Issues (20)
- Determination of date and time of forking deadline for Test net rollout of gemini HOT 4
- FIO Fee Update HOT 5
- FIO v2.x required chain update HOT 1
- Determine date and time of forking deadline for Mainnet rollout of gemini release v2.x HOT 8
- setabi corrupted the ABI HOT 3
- Need FIO Transaction History Solution for Wallets and Exchanges HOT 1
- fio.fee Set fee vote -- when the number of fees voted is 70 fees, RAM usage exceeded error for BP accounts not in the schedule HOT 3
- FIO Upgrade/Migration to EOSIO 2.0.x codebase HOT 2
- centos How to install nodes HOT 3
- Build fail HOT 12
- FIO - AWS Cloud/Devops Engineer HOT 1
- QA and Test Automation Engineer HOT 1
- QA Javascript Developer HOT 1
- Bug - variant error using create_key over API
- QA and Test Automation Engineer HOT 1
- FIO Integration Engineer HOT 1
- Member access within null pointer detected via Libfuzzer & UndefinedBehaviorSanitizer HOT 1
- How do I get the real fee of the transaction HOT 7
- fixed HOT 2
- Converted time in send_response body is a year ahead HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fio.