Comments (8)
We are doing other ABI updates for the next version. Included this in the list.
from fio.
The appropriate type should be uint64
. This should not break the contract or cause a table migration post change. @ericbutz might want to move this to 1.1 tasks.
from fio.
it breaks the decoding of state history, so data analysis becomes difficult
from fio.
Performed some local tests, setting new abi had no negative impact operation wise. Can continue to register and read domains from table. Concerns regarding decoding state history remain and needs further discussion.
from fio.
Resolved by #78
from fio.
Updating to uint64 broke the setcode for the system contracts. Need to troubleshoot this. Reopening.
from fio.
Updates: No issues are apparent when spinning up a new blockchain with these contracts.
When testing in devnet @dapixcasey found changing the domain expiration abi type to 64 can result in domain table read failures from the system contract voting.cpp. uint32_t value appears to be used instead of uint64_t and changing the domain expiration type and setting the abi on a live state would require multiple table migrations.
from fio.
Fixed by: #78
Release: https://github.com/fioprotocol/fio.contracts/releases/tag/v2.1.0
Closing
from fio.
Related Issues (20)
- Determination of date and time of forking deadline for Test net rollout of gemini HOT 4
- FIO Fee Update HOT 5
- FIO v2.x required chain update HOT 1
- Determine date and time of forking deadline for Mainnet rollout of gemini release v2.x HOT 8
- setabi corrupted the ABI HOT 3
- Need FIO Transaction History Solution for Wallets and Exchanges HOT 1
- fio.fee Set fee vote -- when the number of fees voted is 70 fees, RAM usage exceeded error for BP accounts not in the schedule HOT 3
- FIO Upgrade/Migration to EOSIO 2.0.x codebase HOT 2
- centos How to install nodes HOT 3
- Build fail HOT 12
- FIO - AWS Cloud/Devops Engineer HOT 1
- QA and Test Automation Engineer HOT 1
- QA Javascript Developer HOT 1
- Bug - variant error using create_key over API
- QA and Test Automation Engineer HOT 1
- FIO Integration Engineer HOT 1
- Member access within null pointer detected via Libfuzzer & UndefinedBehaviorSanitizer HOT 1
- How do I get the real fee of the transaction HOT 7
- fixed HOT 2
- Converted time in send_response body is a year ahead HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fio.