Comments (5)
I'm not sure what this issue is getting at. Isn't this already implemented?
from profiler.
The thing that we already have shows "tracing" markers (i.e. markers with a start time and an end time), but not point-of-time markers. For point-of-time markers, the old cleopatra would overlay vertical lines onto the ThreadStackGraph, and every line had a piece of text with the marker name attached to it.
I've written the start of a component that implements this (ThreadMarkerOverlay
), but it's not being used, and I'm not sold on the idea of squeezing even more information into the stuff at the top.
We do need to display it somewhere, though. Mike Conley is the person who asks me about this the most.
Examples for such markers are the "Invalidate" and "Bailout" markers from JS (too many to be useful), "AsyncTabSwitch:Start", "AsyncTabSwitch:Finish", "AsyncTabSwitch:SpinnerShown", "AsyncTabSwitch:SpinnerHidden", and some others that you can find with these code searches.
from profiler.
Seems like a good candidate for moving to the Timeline.
from profiler.
Closing this for now, it's old and I'm not sure what we want to do here.
from profiler.
I believe we can already achieve this by clicking on a marker as it will add the selection's vertical line. (we need to fix the alignment bug of course)
from profiler.
Related Issues (20)
- Add a short section that explains how to share a profile to the homepage
- Profiling sources of JS garbage no longer works? HOT 4
- Loading this profile is too slow HOT 1
- Document power profiling
- There is a gap between the JavaScript radio button and its label HOT 1
- When lots of functions are dropped, they're not easy to manage in the UI HOT 5
- An error occurred in Firefox Profiler
- An error occurred in Firefox Profiler HOT 1
- Misleading URL in "Collapse resource" context menu item HOT 2
- An error occurred in Firefox Profiler
- An error occurred in Firefox Profiler HOT 2
- An error occurred in Firefox Profiler HOT 1
- new HOT 1
- 5
- Automatically open zip files with a single profile
- An error occurred in Firefox Profiler HOT 1
- Don't show "Lookup function name on Searchfox" in Single tab view
- Using Profiler without internet
- "RangeError: invalid digits value: NaN." when loading a profile HOT 2
- In the documentation, make the link to matrix more obvious
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from profiler.