GithubHelp home page GithubHelp logo

Weekday search off by one about convertdate HOT 3 CLOSED

fitnr avatar fitnr commented on July 17, 2024
Weekday search off by one

from convertdate.

Comments (3)

fitnr avatar fitnr commented on July 17, 2024

The function's comments are wrong - the weekday is running from 0=Monday to 6=Sunday.

The following gives the correct answer:

from convertdate import hebrew, gregorian, utils
shabbat = utils.next_weekday(5, hebrew.to_jd(5775,7,1))
gregorian.from_jd(shabbat)
(2014, 9, 27)

The underlying confusion comes from inconsistencies in Python - the time and calendar modules uses Monday=0, but datetime uses Sunday=0.

For this project, I think sticking with the behavior of calendar probably makes sense, since it's used internally for some conversions. Unless you have strong feelings about it, I'll patch the comments shortly and add a note in the docs.

from convertdate.

fitnr avatar fitnr commented on July 17, 2024

Resolved by 03e77f0.

from convertdate.

cheshirex avatar cheshirex commented on July 17, 2024

Sorry, I missed the notification about your previous comment, and only saw the code update now. That's perfect. Thanks!

from convertdate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.