Comments (5)
I would like some of my env vars to be optional. In config/environment.js
I'm providing default values for non-existing variables.
Yet, whenever I run any ember
command in the terminal, I see this:
[ember-cli-dotenv]: Required environment variable 'COR_DEPLOY_TARGET' is missing.
[ember-cli-dotenv]: Required environment variable 'COR_ROOT_URL' is missing.
It is very annoying.
To work around this, I have to provide empty env vars in every .env-*
file that I have (I'm using per-target env files: local, staging, production) and add logic to treat empty strings as false.
Related piece of code:
Lines 47 to 58 in a3c1b28
from ember-cli-dotenv.
I agree with @lolmaus that it would be nice to have optional keys. I may have a bit of time to work on this, but there are a few ways this could maybe work:
-
Add a
clientRequiredKeys
property. Keys inclientRequiredKeys
would be required (fail automatically if missing). Keys inclientAllowedKeys
would remain optional with a change to no missing key warnings. At this point, I thinkfailOnMissingKey
could be deprecated because you'd have finer-grained settings. -
Do option 1, but also add a
warnOnMissingKey
property with a default oftrue
. This would give a heads up on a missing key inclientAllowedKeys
(similar to current behavior), but the warnings could then be suppressed by setting it tofalse
. This would basically keep the current behavior ofclientAllowedKeys
(optional, with suppressible warning), and give us required keys also. -
Just add a
suppressMissingKeyWarnings
property which defaults tofalse
. If true, it'd just skip theconsole.warn
and all other logic would remain the same. Feels a bit like a bolt-on though.
Maybe someone else has a better idea though.
from ember-cli-dotenv.
@devinus can you add more information? Unclear what you mean by exists
checking.
from ember-cli-dotenv.
@lolmaus unsure when I'll get around to it, but will happily review any PRs related to solving this.
from ember-cli-dotenv.
It would be nice to be able to specify required vs optional keys in different environments. I have some keys that are required in production but not in dev/test.
from ember-cli-dotenv.
Related Issues (20)
- FastBoot support HOT 10
- Picking a specific dotenv file via CLI param HOT 2
- Installing gives errors somekey is not defined
- ignore exports in variable defs HOT 1
- Make .env.production effective on ember s -prod HOT 1
- This addon is incompatible with [email protected]+ HOT 47
- Unable to install v2.0 HOT 2
- Ability to check for variable presence HOT 5
- `config/dotenv.js` does not respect environment assumed from `ember deploy prod` HOT 5
- Release a new version to npm? HOT 1
- path option doesn't behave well with ember-cli-deploy's development workflow HOT 9
- Started getting this.ui.warn error since yesterday HOT 1
- Installation fails with "Cannot read property 'clientAllowedKeys' of undefined" HOT 5
- Travis missing ENV vars HOT 2
- Use failOnMissingKey in CI build HOT 5
- The default lookup path of .env is not documented HOT 2
- Environment not recognized correctly while using ember build --prod HOT 2
- Fix CI HOT 1
- env vars not loaded in `.ember-cli.js` HOT 1
- Use for local development only HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-dotenv.