GithubHelp home page GithubHelp logo

Comments (2)

fivetanley avatar fivetanley commented on July 19, 2024

I have no idea what the right answer is here. I'm open for anything that works! We can bump via semver so we don't break existing user's apps if they're using the carrot or tilde operator in npm. #1 sounds good to me, but I'm not sure the right hook to get it. We definitely need the this.app stuff so we can load the right file based off the app's path.

from ember-cli-dotenv.

zilkey avatar zilkey commented on July 19, 2024

OK - I think that PR should do it.

Basically here's what happened (correct me if I'm wrong):

  • dotenv loads things into process.env (server keys + client keys)

  • this package does an extra step of loading those keys directly onto our environments, so we can do the following without mucking with our config

    export default DS.ActiveModelAdapter.extend({
      host: ENV.ADAPTER_URL
    });
    
  • the docs are out-of-date, and so lots of developers probably still have this code:

    // config/environment.js
    module.exports = function(environment){
      return {
        MY_OTHER_KEY: process.env.MY_OTHER_KEY
      }
    };
    
  • a recent change made it so that the new, more awesome way still works, but the old set-it-yourself-in-environment-js was broken

If I got that right, then this PR should fix it. It basically allows the old way (from the README) to work, and the new way also still works and still only loads client keys.

from ember-cli-dotenv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.