When payload is an empty object append entity attributes shall return 400 about context.orion-ld

[kzangeli]

Right now, the broker responds like this:

HTTP/1.1 404 Not Found
Content-Length: 143
Content-Type: application/json
Date: Mon, 06 May 2019 10:05:47 GMT

{
  "type": "http://uri.etsi.org/ngsi-ld/errors/BadRequestData",
  "title": "Entity does not exist",
  "details": "urn:ngsi-ld:doesnotexist"
}

It's not a bad response.

It is also not a bad response to complain about the empty payload.
It's all about the order in which the errors are detected.
If you think that the empty payload should be detected before the non-existing entity, I have no problem with that.
But, I would implement this check in one place only, for all possible requests.
If a payload comes in empty, the broker will return a 400 Bad Request whatever the URI PATH is.

Is that OK?

[kzangeli]

I implemented the check for "{}" (the resulting tree after parsing is a single object of type "Object" and with out children) and this is the new response:

HTTP/1.1 400 Bad Request
Content-Length: 113
Content-Type: application/json
Date: Mon, 06 May 2019 10:26:19 GMT

{
  "type": "http://uri.etsi.org/ngsi-ld/errors/InvalidRequest",
  "title": "Empty Payload",
  "details": "{}"
}

Better like that?

[jmcanterafonseca]

Yes, I think an empty payload is an error that should come before, as it has to do with the content of the request, which is totally incorrect. I also agree that this should be unified for any request.

[kzangeli]

Good. Thanks. PR coming soon to a theater near you :)

[jmcanterafonseca]

@kzangeli what happens if the content of the payload is ""? We need to check that case as well. Also if the content of the payload is null or nothing inside ... (empty byte stream).

[kzangeli]

NULL is already taken care of. Empty I think also.
Will add more tests in the functest of this next PR

[jmcanterafonseca]

and "" because "" is also valid JSON but not semantically correct for our API ... and []

[kzangeli]

Fixed in #53

[MohamedSadiq102]

#Verified @jason-fox