GithubHelp home page GithubHelp logo

Comments (9)

asagi4 avatar asagi4 commented on July 28, 2024 1

If you want, you can try my branch: https://github.com/asagi4/AIT/tree/hacks

The fixes in it aren't ready for publication, but it restores compatibility with at least my installation of ComfyUI. It's very WIP though.
I have some local patches in comfyUI too that deal with tensor type issues, so that version of AIT might not be enough.

from ait.

asagi4 avatar asagi4 commented on July 28, 2024 1

EDIT: removed the ComfyUI patch

I updated the hacks branch with a better fix. AIT no longer forces tensors on the CPU, which makes things work properly.

from ait.

asagi4 avatar asagi4 commented on July 28, 2024 1

@FizzleDorf I'll make a PR once I have time to put some thought into it. There's probably more refactoring and cleanup that can be done with the recent updates to ComfyUI, and I'd rather not leave too much useless code lying around.

from ait.

CyberTimon avatar CyberTimon commented on July 28, 2024

Thank you very much. Will try it tomorrow!

from ait.

CyberTimon avatar CyberTimon commented on July 28, 2024

@asagi4 Thank you very much for your fix. Everything works including controlnet!! :)

from ait.

FizzleDorf avatar FizzleDorf commented on July 28, 2024

@asagi4 I caught this kind of late. Thanks for putting this together. You can open the PR early if you like for some more visibility and if you need any help with anything or roll back some recent changes so the merge is more graceful let me know.

from ait.

asagi4 avatar asagi4 commented on July 28, 2024

Looking at https://github.com/gameltb/AIT/ it seems it should be possible to refactor AIT to get rid of the sampler override and a large bunch of the other code in the repository and simplify things greatly, but that fork seems to completely remove downloading precompiled modules.

Rebasing AIT on top of that work and adding in the module downloading is what I'd like to see happen; it seems like it would remove a lot of confusing code that's really difficult to keep compatible with base ComfyUI.

from ait.

asagi4 avatar asagi4 commented on July 28, 2024

I don't know if I'll have the motivation to do that though; Refactoring Python code is painful.

from ait.

CyberTimon avatar CyberTimon commented on July 28, 2024

Yeah it would be cool if you would do that - if you have time and motivation of course. It's quite sad to see how little attention AiT gets.

from ait.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.