Comments (6)
could you possibly update your values.yaml by adding an additional enabledModules
property so that it would look like:
# values.yaml
---
type: object
default: {}
additionalProperties: false
properties:
enabledModules:
type: array
items:
type: string
and give it a try? It seems we unwittingly enforced sort of a requirement for customers' openapi schemas to contain this enabledModules key by having this global values patch applied in the operator's logic.
from addon-operator.
@piotrminkina Hello! Thanks for such comprehensive information!
May I ask to check if any openapi schema is applied to the global values in your case? According to the documentation, you can find it in the $GLOBAL_HOOKS_DIR/openapi directory
from addon-operator.
Yes, I have the following YAMLs:
# config-values.yaml
type: object
additionalProperties: false
required:
- dataMaxLength
- operatorReleaseName
- apps
properties:
dataMaxLength:
type: integer
minimum: 65536
operatorReleaseName:
type: string
apps:
type: object
additionalProperties: false
[...]
# values.yaml
---
x-extend:
schema: config-values.yaml
type: object
additionalProperties: false
from addon-operator.
@miklezzzz It seems that after this change, object updates are implemented correctly. Thanks!
What do you plan to do about it next? Some kind of update in the documentation or what?
from addon-operator.
@piotrminkina We'll try to make it seamless for users by adding missing properties to the final values schema.
from addon-operator.
Fixed in v1.13.3
from addon-operator.
Related Issues (20)
- Implement a way to record events
- Consider implementing more verbose queue metrics
- Store modules settings in separate CRDs HOT 2
- Rethink module 'onStartup' hooks
- Target namespaces HOT 1
- Helm deletion hooks seems not to be obeyed HOT 1
- ModuleReload
- Improve enabled scripts
- Using `exclusiveMaximum` in OpenAPI schema causes an error HOT 2
- Default values in OpenAPI, `patternProperties` are not properly handled HOT 1
- Add the ability to see diff between revisions
- Add schema for module.yaml validation
- Option to configure wait for helm upgrade
- Module is not redeployed if only helm hook changed in the template
- Addon-operator is stuck when number of modules is above certain amount
- Errors in main.go are not logged HOT 3
- Add exported main function HOT 1
- helm client: modules may stuck in pending-upgrade periodically HOT 1
- Module's helm release in uninstalling state doesn't get purged by the operator
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addon-operator.