Comments (5)
also, in code of sticky plugin, "sticky" can mean "a state of being sticky" or "make sticky", which may add some ambiguity
from framework.
https://discuss.flarum.org/d/33369-weird-js-issue-relating-to-extensions-typeerror-t-is-undefined/2 seems to be related to this.
Look at the error:
we can see in the exception stack: loadPage DiscussionListState.ts:43
and when we take a look at addEssentialExcerpt.js
, we will find that only this file in Sticky
plugin imported from DiscussionListState.ts
Also, the function addEssentialExcerpt
makes pinned discussions show a 175-char abstract, which means that its missing can stop the page from loading.
Well, all the above things seems to make sense until I tried a compilation. forum.js
didn't even change, which means that the typo is harmless.
from framework.
the typo is harmless, whatever error is caused in that report, it is most likely due to an extension.
from framework.
If there was really a problem with the naming of the import, the entire extension would fail to compile before it's ever released publicly.
Most imports in Flarum javascript simply take the default
export and give it a name that matches the file so the actual function name in the export rarely matters.
Still something we might want to rename internally, I assume it's a leftover from an older rename.
from framework.
the function was renamed in 2.0 but other then that, nothing to fix here.
from framework.
Related Issues (20)
- Search drivers HOT 2
- Missing Component Exports
- DispatchEventsTrait causes error when event does not have "actor" attribute due to PHP 8.2 deprecation HOT 4
- Setting permissions on mobile does not display correctly on mobile
- PostRepository::getIndexForNumber() walks 2 time the posts table to get offset HOT 6
- Code blocks are hard to read in dark mode HOT 2
- [1.x] `Conditional` extender instantiates the extenders array even when the conditional is false
- Support Invokable Classes in Console Extender's schedule method
- Akismet False Positives Triggered by Flag Removal
- Empty settings don't return default values HOT 13
- Content max limit is incorrect HOT 2
- [2.x] `LogoutController` permits open redirects
- Height of Modals on Mobile Inconsistent
- fttb slow response time
- Invisible buttons when making primary color #ffffff
- Admin page's Save button won't reset if an error occurs HOT 1
- JSON:API Layer Refactor HOT 3
- Cryptograhpically Sign releases HOT 9
- [Pusher] New notifications count increment doesnt work
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from framework.