GithubHelp home page GithubHelp logo

Comments (2)

flashmob avatar flashmob commented on May 20, 2024

There were two reasons;

  1. Wanted to 'extend' the buffio.Reader so that it has a limited reader underneath plus add a setLimit() method to adjust the limit. (Didn't want to allocate a new limitedreader each time)
  2. wanted to 'extend' the limited reader so that the limit could be adjusted. The other problem was that limit reader returned io.EOF when limit reached, but needed a more specific error

from go-guerrilla.

flashmob avatar flashmob commented on May 20, 2024

Thanks for your review btw! After having a second look at it, it looks like the err handling should have been placed inside the limited reader, then there is no need for readLimitedString() - can just use good old bufio.readString()

from go-guerrilla.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.