GithubHelp home page GithubHelp logo

Comments (7)

refi64 avatar refi64 commented on May 24, 2024

Is there a bug filed for the runtime to add this yet? I wouldn't mind adding it here if there's no plans to add it to 21.08 / has an undefined timeline, but if it's coming relatively SOON(tm) I don't want to end up with an accidentally slightly incompatible version or something.

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

No, I haven't reported it myself and didn't see a relevant bug report.

I wasn't sure if the devs would agree to add GTK4 and other libraries to the 21.08 runtime, and it already has libfcitx4 which conflicts with libfcitx5, or at least when using the buildsystem installation target (overwrites some .so symlinks). edit: I dropped libfcitx5, it's not needed for building the module
It's likely possible to add the GTK4 Fcitx5 IM module to the runtime and not affect the exiting GTK3 Fcitx4 module, but it's not the approach I would choose.

An extension that can be reused seems like a good temporary solution until the 22.08 runtime will be available.

I haven't looked at IBus yet, so I can't comment about it.

Anyway, I hoped to get here some feedback, and maybe move this extension solution forward.

Note the existing issues:

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

I added the GTK4 IBus IM module, and at first glance it works correctly, even though gio-querymodules doesn't add it to giomodule.cache.

Fcitx5 has a IBus backend, so it's possible to use the IBus IM module with the Fcitx5 daemon.
The reason one would want to do this is to take advantage of the working popups while still using Fcitx5.
edit: And this is exactly what I'm doing, as I'm running my own updated build of the Fcitx5 Flathub app, testing the ChineseAddons and Hangul extensions (the latter not on Flathub yet).

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

I looked at this again today, and confirmed that Chrome uses GTK4 at least also for the system printing popup window.
The GTK3 CUPS printing backend, and libcups are already bundle in this app and others (some Electron based), so the Flatpak extension approach might not be the best solution, even if makes it possible to avoid bundling GTK4 in every Chromium based app.

The handful Chromium based browsers and CEF based apps can build and package GTK4, the IM modules, and printing backends, if needed.
Electron based apps, if this framework supports GTK4, will be able to use GTK4 and its modules from the base app.

I updated the packaging, and now it's pretty minimal, building and installing just needed dependencies and features.

Other possible changes that can be made:

  • Enable the GTK4 CUPS backend. Especially if it's decided to go forward with bundling the IM modules in the Flatpak app here.
  • Don't build updated GTK3 IM modules.
  • Avoid installing ECM by building it with the Fcitx5 GTK4 modules. See example.

If it's decided to bundle GTK4 and the IM modules in the app, then I can send a PR.

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

I've been testing with Chrome dev builds, so I haven't noticed that we need to wait for Chrome 97, so a PR with my changes won't help much without switching release channel.

I sent a PR to the Edge app, and it's working there, as the Beta channel is on 97.

CUPS backend is also packaged now and working.

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

Oh! Stable due date is today. I'll send a PR.

from com.google.chrome.

tinywrkb avatar tinywrkb commented on May 24, 2024

Closing in favor of adding to Chromium base app.

from com.google.chrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.