GithubHelp home page GithubHelp logo

Comments (9)

sialcasa avatar sialcasa commented on June 9, 2024 1

@flauc @Fenkiou ViewEncapsulation.Native uses native Shadow Dom API that isn't supported by other browsers then chrome yet. But there is a polyfill for it: http://webcomponents.org/polyfills/

from angular2-notifications.

flauc avatar flauc commented on June 9, 2024

As you know i'we added the ViewEncapsulation recently and didn't have a chance to test it. It's just one of thous things that i'm hopping will get smooth out with the new beta releases of angular.

As for the NotificationsComponent i'll rename it right away. You're completely right it's confusing.

from angular2-notifications.

flauc avatar flauc commented on June 9, 2024

I removed the ViewEncapsulation, for now. Because it seams to be working only in chrome. But with ViewEncapsulation removed it now works in both firefox and safari.

from angular2-notifications.

Fenkiou avatar Fenkiou commented on June 9, 2024

Thank you for this. The error is gone now.

Now I'm looking at why my CSS is broken.

from angular2-notifications.

flauc avatar flauc commented on June 9, 2024

You might have some conflicts with your css and the library css. Since there is no ViewEncapsulation they might overlap. I'll add simple-notifications prefix to all of the libraries css.

from angular2-notifications.

Fenkiou avatar Fenkiou commented on June 9, 2024

Nope sorry it was on me...

I used this <simple-notifications></simple-notifications> instead of this <simple-notifications [options]="options"></simple-notifications> and didn't put any options in my @page..

I thought it was possible to use it like this with just :
this.notificationsService.success('title', 'message', options)

It's all good now. Thanks for your help !

from angular2-notifications.

flauc avatar flauc commented on June 9, 2024

It's no problem. Glad you made it work 👍

from angular2-notifications.

flauc avatar flauc commented on June 9, 2024

Yes but i want to keep the library lightweight with as little dependencies as possible.

from angular2-notifications.

sialcasa avatar sialcasa commented on June 9, 2024

Ah - I saw you prefixed your CSS classes - this is a good solution!

from angular2-notifications.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.