GithubHelp home page GithubHelp logo

Comments (7)

moio avatar moio commented on July 24, 2024

Those functions are actually needed by the scanner - see json_scanner.yy in the number rules. The correct solution would be to add the conditional defines in the "%{ %}" block at the top of the file, re-run flex and then bison.

I do not have access to a Win32 development machine at the moment, can you verify that the solution works and submit a pull request, please?

from qjson.

flavio avatar flavio commented on July 24, 2024

The issue should be fixed inside of the issue_23 branch. Could you please checkout the code and test it?

from qjson.

flavio avatar flavio commented on July 24, 2024

@garrrrr have you been able to test my fix?

from qjson.

g30rg avatar g30rg commented on July 24, 2024

I wonder, why nobody ever confirmed this fix.
My current setup is a Win7 Machine 64bit, with VS2010 and VS2012 installed. I tested your issue_23 branch on both VS2010 and VS2012 as a 64bit build and it works just fine for me.

from qjson.

flavio avatar flavio commented on July 24, 2024

Great, I'll merge the branch in master and close this issue.

from qjson.

flavio avatar flavio commented on July 24, 2024

Fix merged in master.

from qjson.

gantony avatar gantony commented on July 24, 2024

Hi think we should re-open this. It seems that the fix broke the build under MinGW, as described in my comment for issue #26.

There probably is a way to use something more specific to VS2012 instead of #ifdef _WIN32.
Not sure exactly how to fix this, but I can try a fix if suggestions are made. I run Qt 4.8.4 with MinGW on win 7, but also have a version of VS 2012 installed.

from qjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.