Comments (6)
Yes, thanks! That's clarifying things. I will when I can find time to work on this. I'm kind of busy right now with other stuff.
In the meantime, for everyone who needs multi-table support you can use this older version
pod 'BartyCrouch', :git => 'https://github.com/Flinesoft/BartyCrouch.git', :commit => 'a31aef6ad183b42b7b3dfc2e5e2c07bb212594ac'
and install it manually on pod install
by adding this to your Podfile
post_install do |installer|
Pod::UI.info "Installing BartyCrouch manually"
system("make installables -C ./Pods/BartyCrouch --silent")
system("cp -f /tmp/BartyCrouch.dst/usr/local/bin/bartycrouch ./Pods/BartyCrouch/bartycrouch")
end
from bartycrouch.
You're right, supporting multiple tables is currently not in the scope of BartyCrouchs features. I'm not using them myself so I don't have plans to implement support for them in the near future. But I'd be glad to accept a merge request that attempts to add support for localization tables as long as it conforms to the contribution guidelines.
A few steps/places probably related to this feature:
- Add multiple Strings file finding support in
StringsFileSearch
- Add multiple Strings file generating support in
CommandLineActor
Also one question is if those differently named Strings files are all placed within one directory (potentially structured into sub directories). If not than we probably also need new command line options as currently you can only specify a directory to be searched for the resulting Strings files.
I hope this helps driving this feature forward. I'm sorry that I can't implement this feature myself (I'm currently too busy), therefore I will need the support of the community to get this done. But I'll try to be of help as good as I can.
from bartycrouch.
I reverted #67 due to side effect problems. Reopening this ticket therefore.
from bartycrouch.
Note that there is now a new option named --custom-localizable-strings
available which you can use. It doesn't exactly solve this issue, but it may be a working alternative until this is properly implemented.
from bartycrouch.
This new option --custom-localizable-strings
makes it a bit harder to implement this feature.
I would expect that occurrences of NSLocalizedString
will search in Localizable.string
if tableName = default
. If the tableName
is specified, I would would expect <tableName>.strings
to be checked.
We now have to determine which name is overridden by --custom-localizable-strings
. @Dschee What was the idea for this in your initial concept?
from bartycrouch.
We currently have a project which is splitted into multiple sub-projects (not my idea) and each sub-project has it's own .strings
-File and those are not allowed to be called the same due to restrictions with our translation service LingoHub. While we could have used a tableName
, not all of our toolset is compatible with that and that's why I introduced a possibility to enforce a file name.
But I don't see any problems with the tableName = default
cause the logic behind the --custom-localizable-strings
is that it enforces a specific file name to replace the default Localizable.strings
file. That means, when the option is set, then the default
should become the specified String instead Localizable
. But if a different tableName
is given, you can still use that and ignore what's specified in --custom-localizable-strings
.
Does that answer your question or concerns?
from bartycrouch.
Related Issues (20)
- Can't build project after upgrade bartycrouch to 4.8.0
- Explicit folders on the `codePaths` argument shouldn't be ignored later. HOT 5
- NSLocationTemporaryUsageDescriptionDictionary translations gets removed HOT 6
- Cocoapods executable doesn't work on x86 machines HOT 19
- Embed lib_InternalSwiftSyntaxParser.dylib into package HOT 3
- error: the target 'SwiftSyntax' in product 'SwiftSyntax' contains unsafe build flags HOT 4
- Support for none default Xcode install path HOT 1
- Add new line on every translation after normalize HOT 2
- Translate successful but no output for Storyboards Main.string file HOT 3
- BartyCrouch with SwiftGen creates empty string values HOT 2
- [Feat] Autogenerate `.strings` files HOT 3
- `overrideComments` option doesn't work HOT 4
- [Bug] CI failed for version 4.12.0 HOT 2
- [Bug] update.code with additive=false and code in multiple parent directories looses strings HOT 5
- [Feat] Tip: How to localize LocalizedStringResource types with bartycrouch HOT 3
- [Feat] Support for modular application HOT 4
- [Bug] Translation Microya.ApiError<Microya.EmptyBodyResponse> error 3 HOT 2
- [Bug] PodSpec does not support iOS anymore HOT 7
- [Feat] Extract localizable Strings from SwiftUI Text HOT 1
- [Question/Bug] : .bartycrouch.toml permission errors on dependent test build HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bartycrouch.