GithubHelp home page GithubHelp logo

Comments (4)

sofkaski avatar sofkaski commented on July 19, 2024

From the debug output:

  1. The second response that contains alarms is: ~20004600806200001000020002000000020000000000000000060000000000000000140002000000020182001000000000000000000010EB21
  2. The part that contains Alarm event 1 - Alarm event 6 is 000200000002. From SEPLOS BMS Communication Protocol_V2.0 .pdf we can interpret this so that Alarm event 2 and Alarm event 6 have non-zero values.

from bms_connector.

sofkaski avatar sofkaski commented on July 19, 2024

I can try to fix this and make a PR for review.

from bms_connector.

sofkaski avatar sofkaski commented on July 19, 2024

I have a fix proposal in https://github.com/sofkaski/bms_connector/tree/fix-alarm-mapping. It contains also unrelated commits that resolve Ruff findings. I was about to make a PR against next-branch as instructed in contributing guidelines, but noticed that the the next-branch is far behind the main. @flip555 could you rebase/merge next-branch to the level of main?

(If I make the PR now, it would look a bit crowded, since it would also include commits from main).

from bms_connector.

sofkaski avatar sofkaski commented on July 19, 2024

I have the version from my branch running in my environment (Seplos V2): Based on first few update rounds it seems to be working, but I would assume to get more alarms tomorrow to see if they are correct.

from bms_connector.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.