GithubHelp home page GithubHelp logo

RTL support about springy-heads HOT 9 OPEN

flipkart-incubator avatar flipkart-incubator commented on September 23, 2024
RTL support

from springy-heads.

Comments (9)

thekirankumar avatar thekirankumar commented on September 23, 2024

Which branch are you on ? Master or "run_in_service" ?

from springy-heads.

thekirankumar avatar thekirankumar commented on September 23, 2024

Can you try the new branch "run_in_service" ?

from springy-heads.

hishambakr avatar hishambakr commented on September 23, 2024

I just used
compile 'com.flipkart.springyheads:library:0.9.6'

I will try "run_in_service" branch

from springy-heads.

thekirankumar avatar thekirankumar commented on September 23, 2024

@Hisham2007 any update ?

from springy-heads.

hishambakr avatar hishambakr commented on September 23, 2024

seems working but there is a crash when i close heads:

FATAL EXCEPTION: main Process: com.springyheads.service.demo, PID: 5463 java.lang.IllegalArgumentException: View=com.flipkart.chatheads.ui.container.WindowManagerContainer$MotionCaptureView{ad91479 V.ED..... ......I. 0,0-1440,2464} not attached to window manager at android.view.WindowManagerGlobal.findViewLocked(WindowManagerGlobal.java:451) at android.view.WindowManagerGlobal.updateViewLayout(WindowManagerGlobal.java:363) at android.view.WindowManagerImpl.updateViewLayout(WindowManagerImpl.java:97) at com.flipkart.chatheads.ui.container.WindowManagerContainer.onArrangementChanged(WindowManagerContainer.java:209) at com.flipkart.chatheads.ui.container.DefaultChatHeadManager.setArrangementImpl(DefaultChatHeadManager.java:389) at com.flipkart.chatheads.ui.container.DefaultChatHeadManager.onMeasure(DefaultChatHeadManager.java:185) at com.flipkart.chatheads.ui.HostFrameLayout.onLayout(HostFrameLayout.java:23) at android.view.View.layout(View.java:17938) at android.view.ViewGroup.layout(ViewGroup.java:5812) at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:2666) at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2367) at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1437) at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7397) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:920) at android.view.Choreographer.doCallbacks(Choreographer.java:695) at android.view.Choreographer.doFrame(Choreographer.java:631) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:906) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:158) at android.app.ActivityThread.main(ActivityThread.java:7224) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)

also circles popup in left. i want them to be right
finally, it was better to be displayed inside app only but this branch open outside app also

from springy-heads.

gssmanc avatar gssmanc commented on September 23, 2024

Many thanks for great effort.
i am doing work on chat head using your library but i have an issue i want to use this code in service .
kindly guide me how can i do this.some guide line about "run in service" branch.
thanks

from springy-heads.

thekirankumar avatar thekirankumar commented on September 23, 2024

@Hisham2007 Can you open a new issue for the crash you reported ? By default chat heads work outside the activity, Optionally, you can use the new code within the app too. Create an issue for that.

from springy-heads.

thekirankumar avatar thekirankumar commented on September 23, 2024

@gssmanc The run_in_service has been merged to master now.

from springy-heads.

HungTDO avatar HungTDO commented on September 23, 2024

@Hisham2007 I solved the problem
Just Check view is attached to window (in WindowManagerContainer.java#onArrangementChanged):

// TODO: ChatHeadLibs: Fix error here (not attached window)
        if (motionCaptureView != null && motionCaptureView.getWindowToken() != null)
        windowManager.updateViewLayout(motionCaptureView, layoutParams);

After resolved that, maybe raise error when minimized chathead. Plz edit code in MinimizedArrangement.java#getBundle()

if (hero != null && hero.getHorizontalSpring() != null) {
        relativeXPosition = hero.getHorizontalSpring().getCurrentValue() * 1.0 / maxWidth;
        relativeYPosition = hero.getVerticalSpring().getCurrentValue() * 1.0 / maxHeight;
    }

All worked.

from springy-heads.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.