updater: Local firmware build detected as "Release", unlike qFlipper about flipper-android-app

[LionZXY]

Fixed by 5ed8ffd

[digitalcircuit]

It's more of a visual bug - the app claims there's an update available (big, green Update button), when instead it should act as if switching update channel, offering to replace the firmware (orange Install button).

qFlipper behavior

qFlipper shows firmware version as unknown and sets the update button to Install, signifying it will replace the existing unknown firmware.

Android app behavior

Current - treats as RELEASE

The Android app acts as if the Flipper is running release firmware and offers to install an update, not making it clear that the "update" will actually be reverting the local firmware build to the official release.

The version parsing is also a bit weird - it's using my local Git branch name (local-region) as if it was a version number.

Expected - treats as custom with option to replace

Firmware on Flipper doesn't match the selected update channel. Selected version will be installed.

This is close to the behavior I'd expect, though the version parsing is still messed up. It'd be nice if the Flipper would distinguish the local firmware version like Dev [commit hash], but in a different color, perhaps Custom [commit hash] or such.

[LionZXY]

Just an amazing bug-report! We will take this to work for sure - it is a first-priority feature.

[digitalcircuit]

I've updated to the latest Android app dev build and can confirm this works.

Thank you!

[LionZXY]

Thank you very much for the bug! I think it's definitely should be fixing.
I understand correctly that the app doesn't allow you to upgrade to the release version if you have custom installed?
Or is it just a visual bug?