GithubHelp home page GithubHelp logo

Comments (3)

graingert avatar graingert commented on July 30, 2024 1

I think we can aclose this then?

from aiometer.

graingert avatar graingert commented on July 30, 2024

you can do this but you'd need to pass the TaskGroup into the amap, and wrap the returned AsyncGenerator with aclosing:

async with anyio.create_task_group() as tg:
    async with aclosing(amap(process, items, tg)) as aiter:
        results = [result async for result in aiter]

from aiometer.

florimondmanca avatar florimondmanca commented on July 30, 2024

@graingert Well indeed, good point. The actual correct comparison would then be this…

(Current situation)

async with aiometer.amap(process, items) as aiter:
    results = [result async for result in aiter]

Compared to this…

(Correct implementation of proposed idea)

async with anyio.create_task_group() as tg:
    async with aclosing(aiometer.amap(process, items, tg)) as aiter:
        results = [result async for result in aiter]

Which instantaneously seems like we don't want amap to change, and the async with (which ensures structured concurrency constraints) + async for is just fine (users would have to add it not to shoot themselves in the foot; and it's likely that an implementation would require the correct implementation anyway, which means there's not even a semi-viable "just async for" alternative).

I think we can close this then?

from aiometer.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.