Comments (3)
I think we can aclose this then?
from aiometer.
you can do this but you'd need to pass the TaskGroup into the amap, and wrap the returned AsyncGenerator with aclosing:
async with anyio.create_task_group() as tg:
async with aclosing(amap(process, items, tg)) as aiter:
results = [result async for result in aiter]
from aiometer.
@graingert Well indeed, good point. The actual correct comparison would then be this…
(Current situation)
async with aiometer.amap(process, items) as aiter:
results = [result async for result in aiter]
Compared to this…
(Correct implementation of proposed idea)
async with anyio.create_task_group() as tg:
async with aclosing(aiometer.amap(process, items, tg)) as aiter:
results = [result async for result in aiter]
Which instantaneously seems like we don't want amap
to change, and the async with
(which ensures structured concurrency constraints) + async for
is just fine (users would have to add it not to shoot themselves in the foot; and it's likely that an implementation would require the correct implementation anyway, which means there's not even a semi-viable "just async for
" alternative).
I think we can close this then?
from aiometer.
Related Issues (9)
- requests as list HOT 2
- Interaction with tenacity retry HOT 5
- swap the stream contexts with the taskgroup context HOT 5
- Update requirements HOT 5
- Handling of exceptions and documentation
- Best practice for handling rate limits HOT 1
- `gather` drop-in replacement HOT 3
- Bump anyio dependency to latest major version HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aiometer.