Make Execute()*-methods return their own error object about pongo2

[ahall]

This is exactly what I was going to ask you about :). So we dont have to parse err.Message() and rely on the format of it.

[flosch]

Ah okay, I thought your main concern was about a nice HTML error page.

Currently, there's only a string returned by the Execute*() methods which can easily be parsed (which is done on the playground, because the current syntax is something like [Line X Col Y] ABC with ABC being the error message). It's a bit inconvinient though so Instead of parsing this string, it will be possible to access the single details in the future. It already was on my TODO (in mind) as I developed the playground, but I somehow forgot about it. Thanks for making me remember.

[ahall]

Yeah first idea I had was the HTML error page, but after you explained to me that it could be done I started having a look at it. Then realised you must be parsing err.Message() on the playground and I was about to ask you if you could implement an error object like you described here, but you were quicker than me :).

[ahall]

Perhaps add the raw contents of the template to the error object? So we don't have to re-parse the file to generate a nice error page?

[flosch]

You mean the specific line? Good idea, will add it.

[ahall]

Yeah that would be useful.

[flosch]

This change and #49 are already live and being used by the pongo2 playground: https://www.florian-schlachter.de/pongo2/

More information about the new error type: https://godoc.org/github.com/flosch/pongo2#Error

[flosch]

Does this work like you expected it @ahall? Please let me know. I'm planning to release a RC for pongo2 v2 in the next few days/weeks, so thorough testing of the new features is highly appreciated.

[ahall]

Thanks @flosch, this works nicely!

[flosch]

Glad to hear.