CountingTask (similar to the CountingExecution) about flowable-engine

[tijsrademakers]

Hi,

Is this something you would like to contribute? Or did you report this issue as an idea to improve performance?

[motorina0]

Hi Tij,
This issue is based on the "Flowable roadmap" wiki page.
I would like to contribute, but I would like to get some feedback on the approach before I start implementing.

[tijsrademakers]

Cool, sub tasks should be handled by the TaskEntityManager I think, because sub tasks are attached to a parent task, not to an execution. The implementation points look good to me.

[motorina0]

Implementation completed. Added unit tests. Updated affected unit tests.

Main changes:

ProcessEngine - updated version, added task relationship count
ProcessEngineConfigurationImpl - added flag enableTaskRelationshipCounts
AddIdentityLinkCmd, DeleteIdentityLinkCmd, RemoveTaskVariablesCmd - call task.forceUpdate() in order to update the identityLinkCount
GetIdentityLinksForTaskCmd - minor change
ValidateTaskRelatedEntityCountCfgCmd, CountingTaskEntity - initial commit
AbstractEntityManager - added logic for task reltionship counting flag state (enabled/disabled
IdentityLinkEntityManagerImpl, VariableInstanceEntityManagerImpl - increase/decrease IdentityLinkCount on instert/delete
TaskEntityImpl - implements CountingTaskEntity
TaskEntityManagerImpl - check identityLinkCount and variableCount before delete
TaskDataManager, MybatisTaskDataManager - added updateAllTaskRelatedEntityCountFlags() method
ProfilingDbSqlSession - call super.flushUpdates() after collecting data
TaskServiceTest, VerifyDatabaseOperationsTest, ChangeTaskCountConfigAndRebootEngineTest - added unit tests identityLinkCount and variableCount
DatabaseTablePrefixTest, DatabaseTablePrefixTest - updated unit test after the new flag was added 
Updated SQL Scripts

Implementation Comments

• Sub-task Count flag not added (yet) for the following reasons:

  • in order to update the flag a new update must be made on the parent task for the subTaskCount flag
  • we would add two update statements (on sub-task create and delete) in order to remove one select statement (select all sub-tasks when the parent task is completed)
  • not sure of the possible concurrency side effects if the (parent) TaskEntity is being updated and at the same time a sub-task is being completed (this trying to update the count on the parent).

• Some Commands now have a task.forceUpdate() in order to update the variableCount and indentityLinkCount: AddIdentityLinkCmd, DeleteIdentityLinkCmd, RemoveTaskVariablesCmd

[tijsrademakers]

Merged the PR, thanks!