Comments (13)
Sorry, I pulled the wrong branch, my bad.
from rosedb.
@taroim Thank you for your feedback, this PR can solve the problem you mentioned.
from rosedb.
In version 2.2.3, the Iterator method has been removed. Why?
from rosedb.
@Jeremy-Run After updating to version 2.2.3, the execution result remains unchanged, and the issue doesn't seem to be resolved.
from rosedb.
In version 2.2.3, the Iterator method has been removed. Why?
@facework
The version 2.2.3 does not exist, do you mean 2.3.x? 2.3.x has not been released yet.
As to why the iterator is removed, this Issue should help you.
from rosedb.
@Jeremy-Run After updating to version 2.2.3, the execution result remains unchanged, and the issue doesn't seem to be resolved.
@taroim pr hasn't been merged into the main branch yet, wait for @roseduan review.
from rosedb.
In version 2.2.3, the Iterator method has been removed. Why?
The iterator replies on the IRadix data structure, but after our tests, the IRadix will occupy lots of memory when the database grows larger.
So we decide to use BTree as the memory data structure instead of IRadix.
Then we add some similar methods to do the same thing with the previous iterator: Ascend and Descend.
So next release the iterator will be removed, if you have any troubles, please feel free to give us feedback.
from rosedb.
This problem has been resolved, please update to the latest commit, thanks. @taroim
from rosedb.
It's usable, thank you.
from rosedb.
package main
import (
"fmt"
"github.com/rosedblabs/rosedb/v2"
"github.com/rosedblabs/rosedb/v2/utils"
)
func main() {
options := rosedb.DefaultOptions
options.DirPath = "./tmp/rosedb_merge"
// merge after insert
db, err := rosedb.Open(options)
if err != nil {
panic(err)
}
for i := 0; i < 10; i++ {
_ = db.Put([]byte(utils.GetTestKey(i)), utils.RandomValue(100*1024))
}
_ = db.Merge(true)
_ = db.Close()
// merge after deletion
db, err = rosedb.Open(options)
if err != nil {
panic(err)
}
fmt.Printf("KeysNum=%v, DiskSize=%.2fMiB\n", db.Stat().KeysNum, float64(db.Stat().DiskSize)/1024/1024)
for i := 0; i < 10; i++ {
_ = db.Delete([]byte(utils.GetTestKey(i)))
}
_ = db.Merge(true)
_ = db.Close()
// open statistics again
db, err = rosedb.Open(options)
if err != nil {
panic(err)
}
fmt.Printf("KeysNum=%v, DiskSize=%.2fMiB\n", db.Stat().KeysNum, float64(db.Stat().DiskSize)/1024/1024)
_ = db.Close()
}
First Execution Result:
KeysNum=10, DiskSize=0.98MiB
KeysNum=0, DiskSize=0.00MiB
Second Execution Result:
KeysNum=10, DiskSize=0.00MiB // Here, DiskSize = 0 !???
KeysNum=0, DiskSize=0.00MiB
from rosedb.
I will fix it later.
The Merge operation has some changes recently, so it may be unstable.
from rosedb.
package main import ( "fmt" "github.com/rosedblabs/rosedb/v2" "github.com/rosedblabs/rosedb/v2/utils" ) func main() { options := rosedb.DefaultOptions options.DirPath = "./tmp/rosedb_merge" // merge after insert db, err := rosedb.Open(options) if err != nil { panic(err) } for i := 0; i < 10; i++ { _ = db.Put([]byte(utils.GetTestKey(i)), utils.RandomValue(100*1024)) } _ = db.Merge(true) _ = db.Close() // merge after deletion db, err = rosedb.Open(options) if err != nil { panic(err) } fmt.Printf("KeysNum=%v, DiskSize=%.2fMiB\n", db.Stat().KeysNum, float64(db.Stat().DiskSize)/1024/1024) for i := 0; i < 10; i++ { _ = db.Delete([]byte(utils.GetTestKey(i))) } _ = db.Merge(true) _ = db.Close() // open statistics again db, err = rosedb.Open(options) if err != nil { panic(err) } fmt.Printf("KeysNum=%v, DiskSize=%.2fMiB\n", db.Stat().KeysNum, float64(db.Stat().DiskSize)/1024/1024) _ = db.Close() }First Execution Result: KeysNum=10, DiskSize=0.98MiB KeysNum=0, DiskSize=0.00MiB
Second Execution Result: KeysNum=10, DiskSize=0.00MiB // Here, DiskSize = 0 !??? KeysNum=0, DiskSize=0.00MiB
I have fixed this in the latest commit, enjoy!
Feel free to give us any feedback, thanks.
from rosedb.
OK, thanks.
from rosedb.
Related Issues (20)
- NEW: Periodically remove expired keys from memory HOT 6
- V2.3.2 Release Plan
- add example code(in examples folder) for TTL (good first issue)
- add example code(in examples folder) for iterating (good first issue)
- Question: Hint file usage HOT 3
- panic: send on closed channel HOT 1
- Suggestion: add a Command for Removing Key Expire HOT 9
- Expired Keys Found in AscendKeys/DescendKeys HOT 4
- Optimize memory usage
- Proposal: keep key and value into memory HOT 3
- Proposal: allow key and value to store per bucket HOT 1
- Proposal: raft protocol support HOT 2
- Possible project use HOT 1
- about replicator HOT 1
- 有个问题,如果key过期了,不执行merge就永远不会删除文件是吗 HOT 9
- is hash ops still supported? HOT 1
- rose.Get panil HOT 10
- Bug: Is it a bug in *Batch.Put? HOT 2
- Proposal: kv db base on remote file system HOT 4
- [BUG] unknown field BlockCache in struct literal of type wal.Options HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rosedb.