Comments (6)
Nobody has been asking for this in three years, so we're going to close it.
from fluentassertions.
I like that.
from fluentassertions.
There is a little bit of a complication to consider here.
.NET does not require an event to be an EventHandler
: any delegate is allowed. That is, there is an existing issue of not having a FA method suitable for asserting against an event of type Action<int, string>.
Removal of the type constraint would make WithArgs
be able to be used in these cases; however, the implementation will give an erroneous failure when/if anyone ever asserts against an Event with repeated Type Parameters ex. Action<string, string>.
It is easy enough to change the implementation so that it handles the case better, my main question is whether this is desired API for these types of assertions.
Example:
public event Action<string, string> Update;
subject
.ShouldRaise("Update")
.WithArgs<string>(args => args == "hi")
.WithArgs<string>(args => args == "bye");
With this API, you would either need to add a restrictions to WithArgs that the method calls have to be ordered, or you would only be able to assert that the given args were used, but not which of the parameters they were used for.
from fluentassertions.
This would make my life much simpler as well :)
from fluentassertions.
I'm almost ready to provide PR for this issue, but I need to know the decision on @vossad01 question about repeated type parameters. My implementation currently sticks with second option. Should I rework it or it is enough just to assert that value was present among arguments of the same type?
from fluentassertions.
You still want to wrap this up?
from fluentassertions.
Related Issues (20)
- Add `BeValidJson` extensions for strings HOT 3
- Add assertions on `JsonElement` HOT 3
- Incorrect line breaks handling with custom string comparer HOT 2
- ComparingEnumsByName() seems not to work as expected HOT 2
- Excluding and Including options should fail when applied on types with value semantics HOT 6
- Compare memberless records by value, others by members HOT 11
- Add support for asserting NaN values HOT 10
- Library is not compatible with .NET MAUI 8.0.6 HOT 3
- Add feature to check if an XElement or XAttribute is absent within the XDocument HOT 16
- Null reference exception when using custom comparer in equivalency options HOT 7
- [Feature]: Multi dimension arrays assertions HOT 10
- WithInnerException<T>() needs the type as a parameter HOT 2
- `Should().BeEquivalentTo` failing for identical objects HOT 3
- FluetntAssertion doesn't work correctly for records HOT 8
- Equivalency assertion option Excluding outputs "value(...<>c__DisplayClass).variableName" in some instances HOT 2
- Add string-option for ignoring newline style HOT 2
- Unexpected default equivalency behaviour with interfaces HOT 3
- ArgumentOutOfRangeException in FluentAssertions.Equivalency.Tracing.StringBuilderTraceWriter.ToString() HOT 8
- FluentAssertions: using a NullorEqual string EqualityComparer still returns a type difference error HOT 2
- [API Proposal]: Allow to assert RegEx matched groups HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fluentassertions.