GithubHelp home page GithubHelp logo

Comments (6)

dennisdoomen avatar dennisdoomen commented on May 18, 2024 1

Nobody has been asking for this in three years, so we're going to close it.

from fluentassertions.

dennisdoomen avatar dennisdoomen commented on May 18, 2024

I like that.

from fluentassertions.

adamvoss avatar adamvoss commented on May 18, 2024

There is a little bit of a complication to consider here.
.NET does not require an event to be an EventHandler: any delegate is allowed. That is, there is an existing issue of not having a FA method suitable for asserting against an event of type Action<int, string>. Removal of the type constraint would make WithArgs be able to be used in these cases; however, the implementation will give an erroneous failure when/if anyone ever asserts against an Event with repeated Type Parameters ex. Action<string, string>. It is easy enough to change the implementation so that it handles the case better, my main question is whether this is desired API for these types of assertions.

Example:

public event Action<string, string> Update;

subject
    .ShouldRaise("Update")
    .WithArgs<string>(args => args == "hi")
    .WithArgs<string>(args => args == "bye");

With this API, you would either need to add a restrictions to WithArgs that the method calls have to be ordered, or you would only be able to assert that the given args were used, but not which of the parameters they were used for.

from fluentassertions.

Tdue21 avatar Tdue21 commented on May 18, 2024

This would make my life much simpler as well :)

from fluentassertions.

okobylianskyi avatar okobylianskyi commented on May 18, 2024

I'm almost ready to provide PR for this issue, but I need to know the decision on @vossad01 question about repeated type parameters. My implementation currently sticks with second option. Should I rework it or it is enough just to assert that value was present among arguments of the same type?

from fluentassertions.

dennisdoomen avatar dennisdoomen commented on May 18, 2024

You still want to wrap this up?

from fluentassertions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.