Add BeSameAs and NotBeSameAs to ReferenceTypeAssertions about fluentassertions

[dennisdoomen]

I agree. It was already on my to-do list to fix that, but thanks for creating a traceable issue for it.

[philippdolder]

Oh. I just saw that it's already moved on latest master, my fault. Would it make sense to also move BeSameAs and NotBeSameAs because this is only checking for reference equality. I'm not sure if it makes any sense for CollectionAssertions though.

[dennisdoomen]

Yes, just noticed that as well. Can't remember when I did that, but obviously before I moved over to Github.

And yes, moving those two methods does make sense.

[paylett]

Yes, please do add BeSameAs and NotBeSameAs to ReferenceTypeAssertions. (I was just about to raise a new issue to suggest it, then I saw this one). Thanks :)

[philippdolder]

I updated the original issue title to prevent misunderstandings.

[dennisdoomen]

Are you still going to pick it up? And if so, within the next few weeks?

[philippdolder]

Yes, I will do it during christmas holiday

[dennisdoomen]

Of course, what else would you do? :-)

[dennisdoomen]

Well, everything is ready for a release. I've updated the documentation (on a wiki branch). I've created a draft release with release notes. We're all waiting for you ;-)

And FYI, I've created a 3.0 branch and converted it to Visual Studio 2013. Will merge it back as soon as we've released 2.2.

[philippdolder]

oh. I'm sorry for letting you wait. I'm just about to work on it :-)

EDIT: btw. you assigned it to Release 3.0 ;-)

[philippdolder]

I cannot build (using BuildRelease.bat) because I cannot import FluentAssertions.WinRT.Specs_TemporaryKey.pfx it needs a passphrase ;-)

[dennisdoomen]

Really? I don't think it is used at all. I just deleted it and builrelease.bat still succeeds.

[philippdolder]

Yes. And it is also referenced from the csproj. After only deleting the file it still not worked (cannot find file for
signing or alike).
After deleting the file and the reference in the csproj.

<PackageCertificateKeyFile>
    FluentAssertions.WinRT.Specs_TemporaryKey.pfx
</PackageCertificateKeyFile>

and playing around more. It still wants the certificate or a certificate with the thumbprint in the certificate store. When completely removing the PackageCertification stuff it complains I should please add a certificate.

I assume you have installed the certificate in your cert-store in windows that's probably why you can delete the file but still build.

It builds in Release mode inside VS and all tests are green (except Silverlight tests don't run, even when I force them, and WindowsPhone specs tell me there are no tests in that project).

But I still can create a pull request if that's ok.

[dennisdoomen]

I never really completely understood this whole .pfx/.snk stuff. The only reason why I signed the unit test project is because the production code needs to be signed and it has an `[InternalsVisibleTo]' attribute referring to the unit test project. So AFAIK an .snk should be enough.

Just sending the PR is sufficient. I'll very the changes for you.

[dennisdoomen]

Thanks!

[philippdolder]

It's my pleasure