string.Should().NotBeNullOrWhitespace() about fluentassertions

[adamvoss]

This behavior would seem to be provided by the existing NotBeBlank() method. The NullOrWhitespace language would be consistent with the static String method introduced in .Net 4.0.

[dennisdoomen]

Indeed, but renaming an existing method would be a breaking change, so I propose to close this issue. What do you think?

[adamvoss]

I can't say that I have a strong preference. I think that in the perfect world the method would be named 'NullOrWhitespace' because that will more likely be what people will look for. 'Blank' does not communicate that null is Blank until you consider it from a UI display perspective. However, is really worth having 2 methods for it until version 3.0 and ultimately making users update existing code? If not then closing it sounds right to me.

[dennisdoomen]

@mpopdam What do you think?

[mpopdam]

I agree that 'NotBeBlank' is not clear enough. You have to look at the documentation to see what it actually asserts. So I would say add a second method for this with the 'IsNullOrWhiteSpace syntax. Mark the other as [obsolete] and remove it in version 3. This is a breaking change, but one that is easy to fix by doing a global find/replace.

[dennisdoomen]

I agree. Let's add the second method and mark the old one as obsolete.