Comments (1)
I believe this this change must be made (
now(&mut self)
-->now(&self)
) or everyTimer
function that needs to access the clock must be passed a &mut of the clock. I don't like the latter for the following reasons:
- Makes usage much more verbose
- Allows usage of different clocks with the same
Timer
I understand. The same thing happens on drivers with the mutable I2C devices. The solution there is to consume the resource and return it upon destruction. See here. The return of the valuable resources can make code messy, though, if doing type-level transformations as highlighted at 2. here (sorry for citing myself again :) I just want to be clear).
Interior mutability would be ok for me. It can be worked around in the driver. It just requires the implementation to contain a RefCell
to a second mutable layer. I used this to implement split()
for the pcf857x I/O expander driver, among others. It is a bit cumbersome but it works. It only adds a CouldNotAcquireDevice
error in case the acquisition failed, which cannot be statically reasoned about.
from embedded-time.
Related Issues (20)
- remove generic Timer struct's State parameter HOT 5
- smarter macros for defining intra-unit conversions HOT 3
- `FixedPoint::integer` is by value, `Generic::integer` is not HOT 4
- New release with the latest update and fixes HOT 4
- Clock with runtime defined SCALING_FACTOR HOT 3
- [Proposal] std-powered Clock implementation for tests HOT 5
- optimize generic Duration usage
- change other integer-returning functions to return by value rather than reference HOT 1
- add checked_add and checked_sub to FixedPoint
- add multiplication of Rate by Duration types and vice-versa
- add suffix abbreviations to Format implementation
- Duration type conversions are difficult to use in practice HOT 1
- How to get the number of elapsed milliseconds as integer from a clock? HOT 1
- Remaining/Elapsed timer calculation for generic clock HOT 2
- Calculating ratios is awkward and fragile
- Comparison of sub-second duration::Generic is broken
- Test suite assumes that tests run one at a time rather than in parallel
- Async support
- How to get an instance of `Clock`?
- Expose Timer's Expiration Time
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from embedded-time.