Comments (5)
We can have an interim period if we think it's warranted, but during that time, if we have it, we'll just keep the grpc library around.
I'd rather not have both of them at the same time, but @eapolinario had some concerns about our ability to test all the various oauth setups out there, so that's a valid concern. But I still think refactoring remote is a different (needed, but different) issue from removing grpc and eventually protobuf dependencies.
from flyte.
I would think that we should only keep rust and let people add the python one back as an extra. I want us to test the rust one well before we release / merge.
Are we also supporting all auth implementations in the rust Grpc channel interceptor?
from flyte.
I don't like the current structure of FlyteRemote at all. It definitely needs to be refactored, heavily. But I'm not sure I understand this ticket. Why is raw.py
still here? That file should be deleted, and all auth handling (which is the tricky part) moved over to the rust core.
from flyte.
That makes sense to me the Python raw.py
should be deleted eventually.
@wild-endeavor I'm curious about your thoughts on the interim.
Why is raw.py still here?
Will there be no transition stage during which two raw.py
files exist at the same time?
We can choose which to use, and will help us test whether high-level behaviors are the same.
from flyte.
My initial thoughts on the way of refactoring are,
flytekit/
remote_utils/
backfill.py
data.py
entities.py
executions.py
interface.py
lazy_entity.py
remote_callable.py
remote_fs.py
remote/
remote.py
Both of
flytekit/
remote/
remote.py
and
flyrs/
remote/
remote.py
can use flytekit.remote_utils
cc @pingsutw
from flyte.
Related Issues (20)
- per-execution interruptible flag not piped through via flytekit HOT 2
- Use ImageSpec as default task image HOT 1
- [Docs] improve docs on eager workflow remote execution HOT 3
- [BUG] `Promise`s are infinite Iterators HOT 3
- [BUG] Container overrides broken in flytekit 1.11.0 HOT 3
- [Core feature] Support patching subworkflows in unit tests HOT 2
- [BUG] ShellTask ctx.secrets accessors not working with AWS Secrets HOT 4
- [BUG] flytectl unit tests failing HOT 2
- [Core feature] Support for Native JSON types in flyte HOT 6
- [Core feature] Flytekit should support `unsafe` mode for types HOT 2
- [Core feature] Flytekit support for positional args HOT 2
- [Core feature] Flytekit create automatic bindings for Task default values HOT 3
- [UI Feature] Add CSS customization option for optional visual indicator with accent color to distinguish separate deployments HOT 1
- [BUG] Subworkflow status is not reported to the parent workflow HOT 7
- [Core feature] Improve flytekitplugins-kfpytorch user experience with default pod template and other reasonable defaults HOT 1
- [Core feature] UX improvement: support local pip-installable packages in `ImageSpec` and `pyflyte run --remote` HOT 3
- [Core feature] Rust Flytekit Remote Client HOT 2
- [Housekeeping] Use uv to cut on build time
- [BUG] Flyteconsole has hardcoded port HOT 1
- [Housekeeping] Fixing some typos in flyteconsole
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flyte.