GithubHelp home page GithubHelp logo

Comments (5)

novahow avatar novahow commented on June 12, 2024 1

#take

from flyte.

runllm avatar runllm commented on June 12, 2024

The issue with the flytectl upgrade command breaking after the monorepo migration is known. The error traces indicate issues with unexpected EOF and missing backups for rollback. This is likely due to changes in the repository structure and dependencies.

Would you like more details on potential fixes or workarounds?

Sources:


This is an AI-generated response and your feedback is appreciated! Please leave a 👍 if this is helpful and 👎 if it is not.

Mention @RunLLM to ask follow-up questions. See runllm.com for more!

from flyte.

eapolinario avatar eapolinario commented on June 12, 2024

The work here has to do with how to list flytectl releases from the monorepo and use that list of releases as opposed to all releases.

More specifically, we use https://github.com/mouuff/go-rocket-update to provide this self-upgrade functionality, the issue is that when we check the releases this library ends up calling a github API that doesn't return the flytectl releases (which use git tags of the form flytectl/vX.Y.Z).

Resolving this issue will require some investigation. Here are some ideas:

  1. implement a new provider that understands flytectl releases (similar to how we do in
    releases, _, err := g.ListReleases(context.Background(), owner, repoName, &github.ListOptions{
    )
  2. use the zip provider (given that we download the new release separately).

from flyte.

novahow avatar novahow commented on June 12, 2024

@eapolinario Hi, I investigated the issue and implemented a new provider. I'm curious about how flytectl upgrade used to work before moving to monorepo? because according to

if isGreater, err := util.IsVersionGreaterThan(latest, stdlibversion.Version); err != nil {

latest infers smth like "v0.8.20", and stdlibversion.Version is the version tag of flyte, which may be "v1.12.0" . How did this comparison work before the monorepo migration?

from flyte.

eapolinario avatar eapolinario commented on June 12, 2024

latest infers smth like "v0.8.20", and stdlibversion.Version is the version tag of flyte, which may be "v1.12.0" . How did this comparison work before the monorepo migration?

before the monorepo migration, stdlibVersion was the current version of flytectl as defined here. Notice that the before the move to the monorepo this referred to git tags of the flytectl repo.

from flyte.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.