I fear we messed up about snapdrop-android

[fm-sys]

yea i see, i feel like that doesnt work at all, bacause onDestroy isnt always called...

Yes, when reinstalling at the emulator it doesn't get called, but under real life conditions it's mostly fine.

BTW, I really appreciate your continuous work for Snapdrop for Android - reduce the code/maintain complexity and making it better from user perspective. Thanks for your help!

[ueen]

#74

[fm-sys]

I suspect that it may have something to do with loadAgain it seems somewhat hacky to me, could you explain why you implemented it and if it could be removed?

For sure this is a very hacky workaround. Actually I tried to remove that workaround before releasing the new version but somehow the app shows itself as peer which is gone after a website reload. But I can try to debug into it again...

[ueen]

The PR fixes the injection isssue.
Yea the showing itself seem to be due to this code

if (onlinePastThreeMin()) {
            WebStorage.getInstance().deleteAllData();

            cookieManager.setCookie("https://snapdrop.net/",
                    "peerid=" + UUID.randomUUID().toString() + ";" +
                            "path=/server;" +
                            "max-age=86400;"
            );
        }

if removed it doesnt show itself anymore...well sometimes it does if you quit and reopen fast...but only once - with this code sometimes the app is creating 3 peers or more
Is this code requiered for anything else?

[fm-sys]

Is this code requiered for anything else?

It was required when using my github fork, but probably not when using the original website. Thanks for finding the fix 😃👍

I will try your PR and report back...

[ueen]

I have to say it seems no different if this code is remved or not and i also encountered the app showing itself sometimes with loadAgain and the cookies so i think we can remove that code, then at least the js injection works, but the showing itself issue remains...let me see if i find something int the snapdrop repo

[ueen]

here it is RobinLinus/snapdrop#215
i'm not sure though how to interpret this...maybe we need to send the goodbye to the server before when the app i closed for good?

[fm-sys]

I tried to do that in the onDestroy method via leaving the website which works in most cases rather well

[ueen]

yea i see, i feel like that doesnt work at all, bacause onDestroy isnt always called...

[ueen]

Maybe this is only an issue if the app is force closed and reopened, which should be rare under real life conditions, i'll test some more, but i think removing the cookie and loadAgain is a good idea either way, because they do not fully prevent the app from showing itself and add other bugs.

EDIT: yea that seems to be the case, there are no duplicates if the app is

• in the background long enough
• the app is closed and opened after a few minutes (2-3)

so you can safely merge :)

[ueen]

sure no problem, this was really bugging me :P