comp_cumulative_returns() weird behaviour about finquant

[opoloko]

Ok did more tests. If leaving NaN it works, but it does cut any previous data not available, so it only calculates the date range that is common across all stocks in portfolio. I had a look at function, and it uses dropna() to cut, that's not ideal I think.

Solution is to use bfill() in the input dataframe before passing it to portfolio, that way any NaN value (for stocks starting later than others in portfolio) are filled with the first known price, and volatility and returns are correctly calculated and considered 0.

[vanderheijden86]

Hi @opoloko, I'm currently also using this repo to do some portfolio analysis. I think I will encounter the same issue as you do above. Thanks for your reply to the question. Another issue that you could be facing, and I will be facing, is on re-balancing the portfolio. In real-life I would rebalance my portfolio on a yearly basis, yet there is no function to do this. Is this not necessary given the way it calculates returns? Or do you think we would need to implement this re-balancing as well to get a realistic result? Thanks already.

[opoloko]

That's another good point indeed. Although rebalancing makes a difference, I tend to do it as little as possible (in real life and in analysis tools).

I definitely think would be nice to have it, but I also use Finquant mostly for pure quantitative/statistic analytics more than a way to calculate a 'real' returns, if you know what I mean.

In a way leaving rebalancing out and having a simple buy&hold makes things more straightforward. But yes I agree would be a nice feature to have.