Add multiple users to lowercase saved rolename dosen't work? about mongomembership

[magahl]

    [Subject(typeof(MongoRoleProvider))]
    internal class When_AddUsersToRoles_is_called_twice : StubsBase
    {
        private static MongoRoleProvider provider;
        private static IMongoGateway mongo;
        private static string roleName;

        private Establish conext = () =>
        {
            roleName = "admin";
            provider = CreateRoleProvider();
            mongo = CreateMongoGateway();

            MembershipCreateStatus status;

            var firstUser = CreateUser("MongoMembershipProviderTest");
            firstUser.Username = "user1";
            firstUser.Id = "userID-1";
            mongo.CreateUser(firstUser);

            var secondUser = CreateUser("MongoMembershipProviderTest");
            secondUser.Username = "user2";
            firstUser.Id = "userID-2";
            mongo.CreateUser(secondUser);
        };

        private Because of_adding_two_users_to_same_role = () =>
        {
            provider.AddUsersToRoles(new[] { "user1" }, new[] { roleName });
            provider.AddUsersToRoles(new[] { "user2" }, new[] { roleName });
        };

        private It should_add_role_too_both_users= () =>
        {
            var roles = provider.GetUsersInRole(roleName);
            roles.ShouldContain("user1", "user2");
        };

        private Cleanup staff = () =>
        {
            mongo.DropRoles();
            mongo.DropUsers();
        };

    }

Failing test to prove redbit86k bug report

[bruyer-k]

There's a bug, the line is defective, it won't work the way it's intended to.

     return UsersCollection
                    .AsQueryable()
                    .Any(user
                        => user.ApplicationName == applicationName
                        && user.UsernameLowercase == username.ToLowerInvariant()
                        && (user.Roles.Contains(roleName.ToLowerInvariant())) || user.Roles.Contains(roleName));

If you read the line, you'll see that it match any user which usernameLowercase is username and which contains the role roleName in its Roles OR any user which has the role roleName in its Roles, which means ANY user, not the one we're looking for.
Since the aim of the function is to determine wether the userIsInRole, that's a bug, we can see it without testing.

The best solution is

     return UsersCollection
                    .AsQueryable()
                    .Any(user
                        => user.ApplicationName == applicationName
                        && user.UsernameLowercase == username.ToLowerInvariant()
                        && (user.Roles.Contains(roleName.ToLowerInvariant()) || user.Roles.Contains(roleName)));

Because we want to be able to add the Role in Lower case or in its 'original case'.

[FoC-]

Ohhhh ')' in wrong place. Great thanks.

[FoC-]

New nuget package is released 0.0.14.