Comments (11)
why does nullguard code in the loader break it?
from costura.
https://github.com/Fody/Costura/blob/master/Template/ILTemplate.cs#L158
ReadExistingAssembly
in the template has to be able to return null.
We could add an attribute. Not sure about the best approach and too brain-dead right now to think about it.
from costura.
how about documenting the loader with a compiler generated attribute and then dont process compiler generated stuff in nullguard??
from costura.
properties are very often compiler gen'd. I'd hate to lose nullguard on properties.
from costura.
when props are compiler gen'ed for they have the compiler gen'd attribute?
On Mon, May 6, 2013 at 9:30 PM, Cameron MacFarland <[email protected]
wrote:
properties are very often compiler gen'd. I'd hate to lose nullguard on
properties.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-17476938
.
from costura.
Autoproperties do, yep.
from costura.
well the property doesnt have CompilerGeneratedAttribute but the getter and setter do.
so if NullGuard had special handling for properties it would work ie
- process all methods that dont have CompilerGeneratedAttribute
- process all getters and setters of properties
Just throwing out ideas here :)
from costura.
That could work. I'd also check iterators and async methods for the CompilerGeneratedAttribute too. I know the internal state machine gets the attribute, but I'm not sure about the method that invokes the state machine.
from costura.
yield
and async
result in the classes having the CompilerGeneratedAttribute
. but none of the methods of those classes have the attribute.
So do we make some assumptions and move forward?
from costura.
I don't see why not. I can work on it this weekend unless you get to it sooner.
from costura.
NullGuard already ignores types that have the CompilerGeneratedAttribute
. So all that should be needed is to add the attribute to the Costura loader type.
from costura.
Related Issues (20)
- win32 dll [DllImport("helloword.dll")] OR [DllImport("helloword.so")] HOT 1
- Files not merging - "Package reference missing 'compile' part in IncludeAssets" HOT 2
- Once i install Costura.Fody to my project and then build.. windows defender catches my app.exe as a Trojan:Script/Wacatac.B!ml HOT 1
- An MSBuild Error that tells you nothing useful HOT 3
- Invalid attempt to merge ffmpeg DLL into C# exe,Has anyone tried that? HOT 1
- Unable to switch languages according to regional settings HOT 2
- Some users have crashes running on windows 7. HOT 1
- FileNotFoundException when using referenced assembly in x64 project HOT 4
- AutoCAD plug-in packaging is not supported HOT 2
- Language Resources Not Being Included HOT 4
- problem virus all virtualtotal. HOT 1
- The type initializer for 'Microsoft.Data.SqlClient.TdsParser' threw an exception HOT 12
- NET Framework 4.8 project: the bin\Release contains37 files. HOT 1
- i think <Costura IncludeDebugSymbols='false' /> disables the disable cleanup HOT 3
- Can't locate embedded satellite assembly HOT 5
- Fody.Costura on multi-target (.NET7 + .NET Framework 4.8.1) Class Library - Failure to Embed Dependencies HOT 4
- Make Unmanaged32Assemblies and Unmanaged64Assemblies works for Linux and macOS executables HOT 1
- Migrate to netStandart HOT 3
- I used Costura.Fody in my project to package it as a class library for others to call HOT 2
- Can support for C++/CLI be added? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from costura.