Costura must be loaded after NullGuard about costura

[SimonCropp]

why does nullguard code in the loader break it?

[distantcam]

https://github.com/Fody/Costura/blob/master/Template/ILTemplate.cs#L158

ReadExistingAssembly in the template has to be able to return null.

We could add an attribute. Not sure about the best approach and too brain-dead right now to think about it.

[SimonCropp]

how about documenting the loader with a compiler generated attribute and then dont process compiler generated stuff in nullguard??

[distantcam]

properties are very often compiler gen'd. I'd hate to lose nullguard on properties.

[SimonCropp]

when props are compiler gen'ed for they have the compiler gen'd attribute?

On Mon, May 6, 2013 at 9:30 PM, Cameron MacFarland <[email protected]

wrote:

properties are very often compiler gen'd. I'd hate to lose nullguard on
properties.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-17476938
.

[distantcam]

Autoproperties do, yep.

[SimonCropp]

well the property doesnt have CompilerGeneratedAttribute but the getter and setter do.
so if NullGuard had special handling for properties it would work ie

• process all methods that dont have CompilerGeneratedAttribute
• process all getters and setters of properties

Just throwing out ideas here :)

[distantcam]

That could work. I'd also check iterators and async methods for the CompilerGeneratedAttribute too. I know the internal state machine gets the attribute, but I'm not sure about the method that invokes the state machine.

[SimonCropp]

yield and async result in the classes having the CompilerGeneratedAttribute. but none of the methods of those classes have the attribute.

So do we make some assumptions and move forward?

[distantcam]

I don't see why not. I can work on it this weekend unless you get to it sooner.

[distantcam]

NullGuard already ignores types that have the CompilerGeneratedAttribute. So all that should be needed is to add the attribute to the Costura loader type.