Comments (16)
I might have a fix for this, but it requires patching the build system. I'll keep experimenting.
from costura.
Patching the build system??? U r making me nervous. Msbuild is very
fragile.
On 18/02/2013, at 6:22 PM, Cameron MacFarland [email protected]
wrote:
I might have a fix for this, but it requires patching the build system.
I'll keep experimenting.
β
Reply to this email directly or view it on
GitHubhttps://github.com//issues/3#issuecomment-13709208.
from costura.
Patching the build system??? U r making me nervous. Msbuild is very
fragile.
Pish posh! You just have to know how to hold it right. π
from costura.
Commited a fix for this on my branch. If you're happy with this I'll merge it in.
Did you want me to just take over this project?
from costura.
more than happy for you to take it over :)
from costura.
@distantcam have u push and updated version that fixes this?
from costura.
some points
- I am really not sure the hoops you have jumped through are worth it when this is only a "nice to have"
- I dont think it will work with package restore. your Copy-Target will not run on restore so people wont have a copy of the targets. Or are people meant to check in the targets? If they are it kind of voids the whole "dont check in packages" approach of nuget.
- the targets approach makes it very "non standard" compared to every other fody weaver. If you want to stick to this approach you need to consider how you will educate users abour the difference. I have already had questiosn from 3 people asking about the targets file.
Either way there needs to be some doco around this
from costura.
π
Does it really matter if the dependency file is referenced, when still developing?
To me what is important is that when I package my project and do not add the dependency file that is embedded, the app works, and that all comes to testing it.
from costura.
It works with package restore because the nuget package copies the target file outside the package to the same place Fody is, which is then presumably checked in. I know the experience of a nuget package adding a target file, only to have said target disappear when deleting the packages folder coughMicrosoft.Bcl.Buildcough
For development, if there is a problem it provides immediate feedback, rather than developing, committing, waiting for build, having app tested and then finding a problem.
Still, if this is an unpopular feature, or it causes too much confusion I can take it out.
from costura.
it is not an unpopular feature. the feature is valid.
But with the current implementation it is a trade off. the options are
- not having this feature and educating people that the references are not deleted
- having this feature and educating people on the targets qwerk
So Option 1 required people to know something. Option 2 requires people to know something and do something.
Also option 2 requires more code on our side.
So I would fall slightly on the Option 1 side.
But i am not adamant about it. I will leave it up to you.:)
from costura.
Well, I am in favour of a smaller codebase. And I'm a fan of KISS principle.
I'll change it back. ;)
On 27/02/2013, at 8:14 AM, Simon Cropp [email protected] wrote:
@distantcam https://github.com/distantcam
it is not an unpopular feature. the feature is valid.
But with the current implementation it is a trade off. the options are
- not having this feature and educating people that the references are
not deleted - having this feature and educating people on the targets qwerk
So Option 1 required people to know something. Option 2 requires people to
know something and do something.
Also option 2 requires more code on our side.
So I would fall slightly on the Option 1 side.
But i am not adamant about it. I will leave it up to you.:)
β
Reply to this email directly or view it on
GitHubhttps://github.com//issues/3#issuecomment-14148498
.
from costura.
should we close this? and perhaps document it somewhere?
from costura.
@SimonCropp I want to add the build script to the source, and then add a wiki page describing how to use it. Then I'll close this issue.
from costura.
go for it
from costura.
Hello - I'm looking for a little more guidance on this topic. FAQ "Creating a clean output directory" ends with "this does not handle ExcludeAssemblies or IncludeAssemblies options mentioned above. You will have to handle these explicitly."
I'm running into exactly that problem with ExcludeAssemblies - I have excluded two assemblies, but they are being deleted during the output directory clean up operation. I guess I don't know my way around project files or the build process very well, so I don't know how to "handle them explicitly" as the FAQ suggests. Can you provide some guidance? Thanks
from costura.
@nmarler For now, just remove the target from your project. There's no harm in having all the assemblies there.
This has given me an idea. We could make the target added to the project smarter and automatically exclude the assemblies from cleanup. Gonna create an issue to discuss this.
from costura.
Related Issues (20)
- win32 dll [DllImport("helloword.dll")] OR [DllImport("helloword.so")] HOT 1
- Files not merging - "Package reference missing 'compile' part in IncludeAssets" HOT 2
- Once i install Costura.Fody to my project and then build.. windows defender catches my app.exe as a Trojan:Script/Wacatac.B!ml HOT 1
- An MSBuild Error that tells you nothing useful HOT 3
- Invalid attempt to merge ffmpeg DLL into C# exeοΌHas anyone tried thatοΌ HOT 1
- Unable to switch languages according to regional settings HOT 2
- Some users have crashes running on windows 7. HOT 1
- FileNotFoundException when using referenced assembly in x64 project HOT 4
- AutoCAD plug-in packaging is not supported HOT 2
- Language Resources Not Being Included HOT 4
- problem virus all virtualtotal. HOT 1
- The type initializer for 'Microsoft.Data.SqlClient.TdsParser' threw an exception HOT 12
- NET Framework 4.8 project: the bin\Release contains37 files. HOT 1
- i think <Costura IncludeDebugSymbols='false' /> disables the disable cleanup HOT 3
- Can't locate embedded satellite assembly HOT 5
- Fody.Costura on multi-target (.NET7 + .NET Framework 4.8.1) Class Library - Failure to Embed Dependencies HOT 4
- Make Unmanaged32Assemblies and Unmanaged64Assemblies works for Linux and macOS executables HOT 1
- Migrate to netStandart HOT 3
- I used Costura.Fody in my project to package it as a class library for others to call HOT 2
- Can support for C++/CLI be added? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from costura.