GithubHelp home page GithubHelp logo

Comments (8)

folke avatar folke commented on July 17, 2024

I can reproduce this. Will check it out!

from noice.nvim.

folke avatar folke commented on July 17, 2024

I checked and the popup completions I get bottom left aren't even coming from the cmdline, but are regular cmp cmpletions.

I'll just implement a simple popup view that looks similar, but doesn't do anything.

from noice.nvim.

folke avatar folke commented on July 17, 2024

The fix was actually easy. The problem was that the cmdline window did not have buftype=nofile set, so the regular cmp also tried to show completions at the same time 😄

from noice.nvim.

akinsho avatar akinsho commented on July 17, 2024

@folke thanks for picking this up so quickly, I can still reproduce the issue on the latest commit unfortunately 🤔

from noice.nvim.

folke avatar folke commented on July 17, 2024

This should be fixed now in the latest version. Things I changed:

  • I made a proper fix to the existing cmp api functions to get the position, screen position and line of the cmdline when Noice is active. Will see to make a PR to cmp that exposes an API to set the cmdline position from other plugins, but this works for now.
  • I implemented a proper cmp source noice_popupmenu that is automatically added when no other cmdline sources have been configured.

With these changes, things should work as expected:

  • cmp popupmenu should always be positioned correctly
  • pmenu items (the ones I get from ui_attach/ext_popupmenu will be used for completion if no other cmp cmdline sources were configured
  • if you're using cmp-cmdline, then that will work as it did before

Let me know if you encounter any more issues!

from noice.nvim.

akinsho avatar akinsho commented on July 17, 2024

@folke that sounds great 👍🏿, I'm not able to test further though as I plan to stay on 0.8 stable rather than nightly and the requirement has understandably been raised to nightly. I've found working on nightly too inconvenient. I'll close these out as is given the changes you've applied 👍🏿

from noice.nvim.

folke avatar folke commented on July 17, 2024

@akinsho I relaxed the requirements back to 0.8.0 for now.

They might change again, if new fixes/functionality becomes available in 0.9.0, but for now, it should work.

You might still want to not use Noice though, if you want a stable Neovim ;)

from noice.nvim.

akinsho avatar akinsho commented on July 17, 2024

@folke just tested it out on 0.8, and it works nicely, both issues are resolved as you say. Totally get you re. changing the requirement up to 0.9 at some point, I understand that maintaining the workarounds might get inconvenient or incompatible with 0.9 changes. Maybe when the time comes to bump it you can leave the 0.8 version in a branch, since presumably/hopefully that should be fine to continue to use as is till 0.9 is released.

Re. Noice's own stability, I'm less worried about a handful of plugins that might not be super stable (as that's easy to disable temporarily) as long as the editor is not playing up around some crucial deadline 🤣

from noice.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.