Multiple notifications for `E486: Pattern not found` about noice.nvim

[folke]

@Shougo good point. Fixed!

[folke]

@pBorak you really shouldn't set lazyredraw. That's not an option meant to be set. Only temporarily inside scripts.

[gennaro-tedesco]

@Shougo you are precisely right, I guess I had just never noticed. Apologies for the noise!

[Shougo]

I think noice.nvim should check lazyredraw option is set and warn.

Because another people have the problem with it.

[gennaro-tedesco]

I am observing that a similar one happens in correspondence of "No write since last changes" (see screenshot):

I have noticed it shortly ago only, not sure if it is intended behaviour or the consequence of one of the latest commits (I mention it here in case it may be useful to debug the original issue as additional information). I may retrieve the logs but they seem to be pretty long: what piece of information is needed?

[folke]

@pBorak I had the same earlier today and on longer see this happen, so I likely fixed it :)

Can you let me know if you still have it?

[folke]

@gennaro-tedesco was probably the same. Does it still happen with the latest version?

[gennaro-tedesco]

I have updated the plug-in but I still observe the same behaviour: see video below to showcase what occurs

Screen.Recording.2022-10-06.at.01.34.39.mov

[Shougo]

It is really bug?
I think just two error messages are generated.

[Shougo]

Please see this.

It is from nvim --clean.

Two error messages are generated. It is not bug.

[Shougo]

So it should be closed?

[pBorak]

Just not yet, I have updated the plugin but still see the same issue.

[Shougo]

Please upload the reproduce instruction.
I will test it.

[pBorak]

@folke
Okay I found the thing that messes this up
If you set vim.opt.lazyredraw to true the issue still occurs.

[folke]

Closing this, since Noice simply won't work correctly when lazyredraw is set

[pBorak]

Thanks for handling it!

[Meow-2]

how to disable this warning? I don't set lazyredraw, but my plugin(vim-visual-multi) may set lazyredraw when I use it and I will see this warning.

[folke]

@Meow-2 they should only set it temporarily, not forever.

[folke]

Or they probbly do disable it afterwards?

[Meow-2]

Or they probbly do disable it afterwards?

Yes, vim-visual-multi only set it temporarily, how can I hide this warning?

[folke]

I jsut added an option. config.health.checker disables the health checker after setup

[Meow-2]

I jsut added an option. config.health.checker disables the health checker after setup

It works, thank you!

[smjonas]

I am also setting vim.o.lazyredraw temporarily inside the preview callback function of my plugin live-command.nvim: https://github.com/smjonas/live-command.nvim/blob/ce4b104ce702c7bb9fdff863059af6d47107ca61/lua/live-command/init.lua#L200

I am not sure why this error is shown because it's reset after running the command. I don't want to disable this error globally so would it be possible to detect that this option was only set temporarily and not show an error message in that case?

[folke]

@smjonas just made a change that checks for lazyredraw during startup only

[smjonas]

Thank you, while that is an improvement, the warning is still shown when previewing the command for the first time, e.g. when typing :Norm A.

[folke]

@smjonas it really shouldn't. Lazyredraw is now only checked during noice startup. So after that even if it is set, we no longer show a warning.

Maybe something else is setting lazyredraw? :verbose set lazyredraw?
Or it doesn't get reset?

[smjonas]

What I have observed is running :set lazyredraw manually after noice has already started (i.e. some messages were displayed), it will still cause the warning to be shown. (I updated noice)

[folke]

@smjonas you're right, sorry. Fixed!

[smjonas]

Thank you, can confirm it's fixed now!