Comments (4)
I like this idea a lot, I think if we could support changing the formats option from:
'formats': {
'domain': 'acme.com`
}
to:
'formats': {
'domains': [ 'acme.com', 'example.com' ]
}
then update the code hitting DNS/Route53 to create both, this could be do-able. I think both would be CNAMEs pointing to the aws resource, rather than acme.com CNAME -> example.com but that would work the same as you describe. Only down side I can think of is that this would enable the second domain for ALL pipelines, but if you are migrating off that may be desired anyway.
from foremast.
@c0debreaker I saw a response in email, but didn't see it here, but for where formats
section is located at is in your config.py settings:
https://github.com/foremast/foremast-template-examples/blob/master/configs/config.py#L59
To address the issue @linjmeyer mentioned:
Only down side I can think of is that this would enable the second domain for ALL pipelines, but if you are migrating off that may be desired anyway.
My thought in the pipeline.json (or application-.json), you can have a section like domains
, where engineers are able to specify what domains to create DNS records in (default: if not provided create in all domains listed in config.py). If you specify domains in the pipeline.json file, they are evaluated against the config.py list to ensure they are "supported."
This enables both parties to both:
- Support multiple domains
- Limit domain if you don't need/want it.
Hope this helps!
from foremast.
That is awesome! Thank you for responding right away! :)
from foremast.
Hey Joel. Neil Camara here. 😊 Yes, I deleted my question because I figured out "formats" property after looking at the code.
Really glad to see your solutions. Looks like putting it in the pipeline.json is nice because developer teams will have the final say on when their applications are ready to be migrated.
Thank you both for keeping this project alive! 💪
from foremast.
Related Issues (20)
- SQS Lambda Event Trigger getting 'BatchWindow' Key Error HOT 3
- The S3 promote_artifacts function is broken HOT 1
- feat: Support Lamda Destinations
- Feature: Support API Key on API-gateway trigger for lambda HOT 1
- Support efs in lambda
- Shared mastered bucket but no common prefix HOT 3
- AWS Print Env Improvements HOT 1
- Support multiple Spinnakers HOT 1
- Support Step Functions HOT 1
- Provisioned Throughput for Lambda Functions
- Support for Glue HOT 1
- Fix GCP Permissions by Group - Labels Delimiter/Character Limit HOT 1
- Media Convert Support
- Fix excessive S3 API Delete Calls HOT 1
- Step Function Triggers HOT 2
- Application Load Balancer EC2 HOT 2
- Support Cloud Scheduler for GCP Cloud Functions HOT 3
- Lambda pipeline fails if new lambda created with S3 bucket trigger HOT 1
- Foremast overwrites s3 event configuration when I use s3 lambda trigger HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foremast.