Supporting several domains during deployment of a resource about foremast

[linjmeyer]

I like this idea a lot, I think if we could support changing the formats option from:

'formats': {
        'domain': 'acme.com`
}

to:

'formats': {
     'domains': [ 'acme.com', 'example.com' ]
}

then update the code hitting DNS/Route53 to create both, this could be do-able. I think both would be CNAMEs pointing to the aws resource, rather than acme.com CNAME -> example.com but that would work the same as you describe. Only down side I can think of is that this would enable the second domain for ALL pipelines, but if you are migrating off that may be desired anyway.

[jvasallo]

@c0debreaker I saw a response in email, but didn't see it here, but for where formats section is located at is in your config.py settings:
https://github.com/foremast/foremast-template-examples/blob/master/configs/config.py#L59

To address the issue @linjmeyer mentioned:
Only down side I can think of is that this would enable the second domain for ALL pipelines, but if you are migrating off that may be desired anyway.

My thought in the pipeline.json (or application-.json), you can have a section like domains, where engineers are able to specify what domains to create DNS records in (default: if not provided create in all domains listed in config.py). If you specify domains in the pipeline.json file, they are evaluated against the config.py list to ensure they are "supported."

This enables both parties to both:

1. Support multiple domains
2. Limit domain if you don't need/want it.

Hope this helps!

[c0debreaker]

That is awesome! Thank you for responding right away! :)

[c0debreaker]

Hey Joel. Neil Camara here. 😊 Yes, I deleted my question because I figured out "formats" property after looking at the code.

Really glad to see your solutions. Looks like putting it in the pipeline.json is nice because developer teams will have the final say on when their applications are ready to be migrated.

Thank you both for keeping this project alive! 💪