GithubHelp home page GithubHelp logo

Comments (3)

edwardwliu avatar edwardwliu commented on June 1, 2024

It sounds like two RandomForest objects will have different seeds when instantiated, but the objects are considered equal since the default value of seed=randrange() is the same. Is this still an issue if we the class explicitly assigns the seed in an initialization or post initialization step (even when the user doesn't provide one)?

from rforestry.

petrovicboban avatar petrovicboban commented on June 1, 2024

Two RandomForest objects will have the same seeds when instantiated. Although, it you re-run script, seed value will be different, but again, the same for both objects.
I don't think we can do it in __init__ and still pass all tests in test_sklearn_compatible_estimator.
The only way to do it is to do it at the start of fit like we do for some other parameters: leave the parameter in __init__ but set default value to None, and then, in fit, check if it's None, and set random value if it is.

from rforestry.

petrovicboban avatar petrovicboban commented on June 1, 2024

Actually, we can't do it. We'll have to move seed to fit parameters.

from rforestry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.