Comments (3)
It sounds like two RandomForest
objects will have different seeds when instantiated, but the objects are considered equal since the default value of seed=randrange()
is the same. Is this still an issue if we the class explicitly assigns the seed in an initialization or post initialization step (even when the user doesn't provide one)?
from rforestry.
Two RandomForest
objects will have the same seeds when instantiated. Although, it you re-run script, seed value will be different, but again, the same for both objects.
I don't think we can do it in __init__
and still pass all tests in test_sklearn_compatible_estimator
.
The only way to do it is to do it at the start of fit
like we do for some other parameters: leave the parameter in __init__
but set default value to None
, and then, in fit
, check if it's None
, and set random value if it is.
from rforestry.
Actually, we can't do it. We'll have to move seed
to fit
parameters.
from rforestry.
Related Issues (20)
- Getting weights variables HOT 1
- Clean up README for Python Package
- Training data column with only NAs
- `has_nas` method defined, but not used
- Export model to JSON string
- Add coverage report for unittests
- :no_good: Branch `bptest/test` has an incorrect name
- Implement Custom Sampling in Python
- Allow all NA or same value columns with scaling HOT 1
- Change linFeats to be 1-indexed instead of 0-indexed
- Python package documentation is outdated
- Fix authentication issue preventing python build pipeline to access docker image
- Build R package and upload it as pipeline artifact
- R release on CRAN - resolve std::cout?
- Add pipeline step for cross language tests / Python pipeline
- Floating point imprecision HOT 3
- Python Predictions not being rescaled when forest is trained with scale = True
- Compatibility with sklearn estimators HOT 6
- segmentation faults when splitratio = 0.5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rforestry.