GithubHelp home page GithubHelp logo

Comments (4)

jpdriver avatar jpdriver commented on July 2, 2024

My two cents here are:-

1 - if the new Expo URL is the same, don't do anything. We could delete and re-post if we absolutely always want the message to be the most recent comment, but that seems like overkill?

2 - if the Expo URL has changed (e.g. different release channel) post a new message and leave previous ones intact.

from appr.

jpdriver avatar jpdriver commented on July 2, 2024

@jevakallio did you want to change the behaviour here? we're currently doing option 2 above, using comparing the whole message and only posting a new one if it's changed (never deleting).

from appr.

motiz88 avatar motiz88 commented on July 2, 2024

It would be awesome to still have some indication within the PR thread that the app has been updated, say with a comment that includes a timestamp, commit hash or both. My model for this is Codecov, which posts a single, data-rich, always-updating comment.

from appr.

jpdriver avatar jpdriver commented on July 2, 2024

@motiz88 I get what you're saying -- but I think that would make more sense if we persisted builds for each commit.

At the moment each branch ( / PR) gets allocated a single Expo Release Channel. Any subsequent commits will update that same Channel, and -- assuming it builds correctly -- the Channel should always be upto date with the latest commit hash.

If in future we created a new Channel for each commit hash, then something like what you've outlined would absolutely make sense. We could have a single comment and continuously update it with new links to each version, wrapped in something like an expanding <details> tag.

But given we don't currently persist commit-level builds, I don't think timestamps and commit hashes would add that much for now. Could be one for the future though! 🙂

from appr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.