GithubHelp home page GithubHelp logo

Support Node 6 about yesno HOT 5 CLOSED

formidablelabs avatar formidablelabs commented on June 18, 2024
Support Node 6

from yesno.

Comments (5)

ryan-roemer avatar ryan-roemer commented on June 18, 2024 1

Added another work item for engines.

from yesno.

mscottx88 avatar mscottx88 commented on June 18, 2024

@ianwsperber @ryan-roemer Can this be done just through changing the target in tsconfig.json from "ES2018" to "ES5"?

from yesno.

ryan-roemer avatar ryan-roemer commented on June 18, 2024

It technically could, but at least for babel, the generated code from async/await is just a monstrosity of awful, so really would be better to have native, terse promises. Maybe we look at the TS generated output for that and see first if it's equally as bad?

... as another factor to consider node6 is EOL'ed April 2019

from yesno.

ryan-roemer avatar ryan-roemer commented on June 18, 2024

One other thing to keep in mind, we only need to do this for src, not examples or test (we could just omit testing 6 in CI). Doing a quick search just yielded only a handful of async/await in actual src.

Easiest path may just be to swap those out, leave CI as is and be done with it!

from yesno.

keithcom avatar keithcom commented on June 18, 2024

node 6 is no longer in LTS

from yesno.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.